Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware: remember installed plugins, hint at user to install them #1663

Closed
fichtner opened this issue May 29, 2017 · 15 comments
Closed

firmware: remember installed plugins, hint at user to install them #1663

fichtner opened this issue May 29, 2017 · 15 comments
Assignees
Labels
feature Adding new functionality
Milestone

Comments

@fichtner
Copy link
Member

(when a config.xml was exported / imported)

@fichtner fichtner added the feature Adding new functionality label May 29, 2017
@fichtner fichtner added this to the 17.7 milestone May 29, 2017
@fichtner fichtner self-assigned this May 29, 2017
@fichtner fichtner modified the milestones: 18.1, 17.7 Jul 21, 2017
@fichtner
Copy link
Member Author

Very cool. Even cooler if more people had the time to work on this... :)

@fichtner fichtner modified the milestones: 18.1, 18.7 Dec 17, 2017
@fichtner fichtner removed this from the 18.7 milestone Feb 27, 2018
@beren12
Copy link

beren12 commented Jun 6, 2018

As a stopgap, can we just list the installed plugins in the config so they are easy to see & reinstall?

@fichtner
Copy link
Member Author

fichtner commented Jun 6, 2018

Not without creating a mapping of config sections and plugins that needs to be in core and synced almost every release. Big process. :)

@fichtner
Copy link
Member Author

fichtner commented Jun 6, 2018

It's probably simpler to register installed plugins in the config.xml by name. If there are testers, I can try to fix it for 18.7 ?

@beren12
Copy link

beren12 commented Jun 6, 2018

No, more simple than that. just a list of non-core plugins that are installed in an xml field. the web UI seems to know already...

@fichtner
Copy link
Member Author

fichtner commented Jun 6, 2018

It asks the package database, yes. But it would be better to fix the real problem first instead of trying to create a "sync" mechanism that writes all currently known plugins to the config. If we have a install/deinstall trigger that is much easier to implement and avoids "over-syncing" and a separate code spot for it.

@fichtner fichtner added this to the 19.1 milestone Jul 15, 2018
fichtner added a commit that referenced this issue Aug 9, 2018
While this works, even for retrospective reinstall, the real issue is
to get to know all the other plugins that are installed but not yet
known like an image-preinstalled os-dyndns.

Second step is how to present the plugins that may be missing in a
sensible way or clickable "install all missing plugins".
@fichtner fichtner modified the milestones: 19.1, 19.7 Jan 9, 2019
@fichtner
Copy link
Member Author

fichtner commented Jan 9, 2019

Code is in there, but GUI parts need more work.

@nekoprog
Copy link
Member

It's probably simpler to register installed plugins in the config.xml by name. If there are testers, I can try to fix it for 18.7 ?

Something like plist can be done? Just a standard flat file with current/previously successful installed plugin name. Then just call the processPlugin($pkg_name, 'reinstall'); I guess. Not having a creative idea right now. lol

@fichtner
Copy link
Member Author

The store is already there, the question is how to use it in the GUI, present reinstall buttons, clear, discard orphaned packages but only when the mirror is up to date because otherwise all plugins look "orphaned".

I'm happy for all help but I am going to be picky here to ensure the feature is as good as it can be when we have it. I don't like to go back and rewrite this again. Sorry in advance. :)

@nekoprog
Copy link
Member

you got a rough design for that? can show me where it should be done? i would like to help with this under your guidance.

fichtner added a commit that referenced this issue Nov 12, 2019
When we install "os-debug" it will deinstall "os-debug-devel" so
we should update our logic.
fichtner added a commit that referenced this issue Dec 16, 2019
When we install "os-debug" it will deinstall "os-debug-devel" so
we should update our logic.

(cherry picked from commit b1702d0)
@fichtner fichtner removed this from the 20.1 milestone Jan 24, 2020
@AdSchellevis
Copy link
Member

@fichtner how about this?
image

AdSchellevis added a commit that referenced this issue Feb 18, 2020
@fichtner
Copy link
Member Author

this is certainly the right direction, but we also need a dismiss button that syncs the current plugin names into the config and we can only install the ones that are really there (do we silently dismiss them or dismiss explicitly?)

also when you change the mirror url and open packages again the missing ones should also be listed if people do offline installs :)

@AdSchellevis
Copy link
Member

There you go, accept captures currently installed plugins, which looks like the most obvious choice here.
image

In time we might need to think about a larger overhaul, the volt template file is growing a bit too much for my taste, but certainly not this year :)

@fichtner
Copy link
Member Author

some more changes done to streamline it a bit and also display missing plugins that are no longer available (while not making them marked as orphaned)

Screenshot 2020-02-20 at 8 35 55 PM

The last bit is moving the action buttons to the dedicated blue upper section and make the page show the actual progress of the reinstall. :)

@AdSchellevis
Copy link
Member

@fichtner looks good, thanks!

fichtner pushed a commit that referenced this issue Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

No branches or pull requests

4 participants