Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall / aliases, refactor and detach alias logic #1971

Closed
AdSchellevis opened this issue Dec 2, 2017 · 9 comments
Closed

Firewall / aliases, refactor and detach alias logic #1971

AdSchellevis opened this issue Dec 2, 2017 · 9 comments
Assignees
@AdSchellevis
Labels
cleanup Low impact changes feature Adding new functionality

Comments

@AdSchellevis
Copy link
Member

As part of the cleanup and restructure operation we're going to refactor and detach the alias logic, the start for this was 70b74c2 . This issue is a placeholder to hook related work for easier tracking.
@AdSchellevis AdSchellevis added cleanup Low impact changes feature Adding new functionality labels Dec 2, 2017
@AdSchellevis AdSchellevis self-assigned this Dec 2, 2017
AdSchellevis added a commit that referenced this issue Dec 2, 2017
@AdSchellevis
firewall / alias, work in progress #1971
a932093
AdSchellevis added a commit that referenced this issue Dec 3, 2017
@AdSchellevis
core, add dependency for #1971
b01a45a
AdSchellevis added a commit that referenced this issue Dec 3, 2017
@AdSchellevis
firewall, alias. work in progress #1971
3503c16
AdSchellevis added a commit that referenced this issue Dec 4, 2017
@AdSchellevis
firewall / alias, work in progress for #1971 missed a check if the al…
c30704d 
…ias filename was already there.
@AdSchellevis
Copy link
Member Author

e51197e

AdSchellevis added a commit that referenced this issue Dec 4, 2017
@AdSchellevis
firewall, aliases. more work on #1971 move port alias parsing out of …
9024f18 
…the way and simplify. the rest of the alias types will be handled by the new python code.
AdSchellevis added a commit that referenced this issue Dec 4, 2017
@AdSchellevis
firewall, alias. remove dependency of filter_expand_alias_array for #…
0df71d2 
…1971
@AdSchellevis AdSchellevis mentioned this issue Dec 5, 2017
Closed
4 tasks
AdSchellevis added a commit that referenced this issue Dec 5, 2017
@AdSchellevis
firewall, aliases. larger blob of work for #1971
5e1ba7d 
This commit fits our new alias code in place, replacing the old parts as far as possible.
*	filter_legacy.inc is added temporary to isolate some functions that should leave before 18.1 and have a relation to aliases
*	The old cron jobs are removed in favour of a new hourly job to our new update_tables
*	The new configd call is "filter refresh_aliases" which triggers the same update_tables as the hourly one
*	All host/network type aliases are replaced with table tags in filter.inc
@fichtner
Copy link
Member

fichtner commented Dec 7, 2017

Reminder for myself: ping https://forum.opnsense.org/index.php?topic=6506.0 when this is ready for wider testing

AdSchellevis added a commit that referenced this issue Dec 8, 2017
@AdSchellevis
firewall, aliases. add basic exception handler on fetching remote url…
1188733 
…. for #1971
@SReign
Copy link

SReign commented Dec 9, 2017

Is there a way to disable Aliases from automatically adding descriptions to individual table records or turning off individual record descriptions completely?

AdSchellevis added a commit that referenced this issue Dec 11, 2017
@AdSchellevis
filter/aliases, make sure only one instance of refresh_aliases can be…
7bcdd7f 
… active, #1971
AdSchellevis added a commit that referenced this issue Dec 11, 2017
@AdSchellevis
firewall/alias, allow ipv4+ipv6 for geoip aliases, #1971
a2b4ef9
AdSchellevis added a commit that referenced this issue Dec 11, 2017
@AdSchellevis
firewall/aliases, cleanup for #1971
aafa261
AdSchellevis added a commit that referenced this issue Dec 11, 2017
@AdSchellevis
firewall/aliases, only touch aliases we know how to handle (create ro…
62e7493 
…om for other types handled differently), for #1971
AdSchellevis added a commit that referenced this issue Dec 11, 2017
@AdSchellevis
firewall/aliases, add externally managed alias type, for advanced scr…
5c213c2 
…ipt usage. for #1971
AdSchellevis added a commit that referenced this issue Dec 11, 2017
@AdSchellevis
firewall/aliases, with #1774 out of the way, we can drop the last leg…
7429a2e 
…acy alias parts for #1971
AdSchellevis added a commit that referenced this issue Dec 11, 2017
@AdSchellevis
cleanup for #1971 , remove unused function
2c03006
AdSchellevis added a commit that referenced this issue Dec 11, 2017
@AdSchellevis
firewall/aliases, support hourly updates for #1971
3038025 
remove update frequency in ports as not being very usefull and the new backend code (filter_core_get_url_port_alias) doesn't support it. Eventually it might be better to drop
support for downloadable port lists.
AdSchellevis added a commit that referenced this issue Dec 18, 2017
@AdSchellevis
firewall/advanced settings, ditch filterdns for #1971
fa72a92
AdSchellevis added a commit that referenced this issue Dec 18, 2017
@AdSchellevis
ditch filterdns, since we've refactored the aliases in #1971 the only…
e8a4fc1 
… use for this is ipsec, but it's doubtful if it's required. see #2003
@fichtner
Copy link
Member

@mimugmail reported this template exception: OPNsense/Filter OPNsense/Filter/filter_tables.conf 'None' has no attribute 'type'

@AdSchellevis
Copy link
Member Author

@fichtner empty alias section, will fix this later on.

@fichtner
Copy link
Member

@AdSchellevis no worries, just wanted to record it for later :)

AdSchellevis added a commit that referenced this issue Dec 20, 2017
@AdSchellevis
firewall/aliases, template missing check for existence. #1971
6ab11f0
@AdSchellevis
Copy link
Member Author

@fichtner fixed in 6ab11f0

This was referenced Dec 20, 2017
Closed
Closed
@mimugmail
Copy link
Member

Is this already in RC2? Im getting:

Jan 16 19:55:22 OPNsense configd.py: error generating template OPNsense/Filter : Traceback (most recent call last): File "/usr/local/opnsense/service/modules/template.py", line 313, in generate for filename in self._generate(template_name, create_directory): File "/usr/local/opnsense/service/modules/template.py", line 248, in _generate raise Exception("%s %s %s" % (module_name, template_filename, render_exception)) Exception: OPNsense/Filter OPNsense/Filter/filter_tables.conf 'aliases' is undefined

But not really sure if there's a relation to this issue ...

@fichtner
Copy link
Member

Was fixed incorrectly, see bba40c9 which will be in 18.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdSchellevis AdSchellevis

Labels
cleanup Low impact changes feature Adding new functionality
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fichtner @AdSchellevis @mimugmail @SReign