Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rule label not just number #2034

Closed
lamixer opened this issue Dec 30, 2017 · 4 comments
Closed

use rule label not just number #2034

lamixer opened this issue Dec 30, 2017 · 4 comments
Labels
support Community support

Comments

@lamixer
Copy link

lamixer commented Dec 30, 2017

Hello. I suggest when the user has requested to show (as a new line) which rule caused a firewall action in the firewall log gui, you show not only the rule number, which is pretty useless by itself, to show the rule number PLUS the LABEL which describes the rule.

I posted a longer explanation here: https://forum.opnsense.org/index.php?topic=6735.msg29086#msg29086

@AdSchellevis
Copy link
Member

The new live firewall log for 18.1 already includes labels
image

Only small detail is that when rules change, the label might be wrong (due to the fact that the label is from the active rule).

@lamixer
Copy link
Author

lamixer commented Dec 30, 2017

That is a nice improvement for the live view... I will certainly enjoy that!

Still, if you are keeping the 'show rule number on a second line' option for the the standard log view, and if it's not too much work, I think you should still consider my suggestion. Thanks.

@AdSchellevis
Copy link
Member

The old log view goes away in 18.1, so there's no real need to change anything there.

@lamixer
Copy link
Author

lamixer commented Dec 30, 2017

Indeed! Makes sense. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Community support
Development

No branches or pull requests

3 participants