Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it obvious that a new cronjob needs to be applied #2101

Closed
Kimmax opened this issue Jan 17, 2018 · 2 comments
Closed

Make it obvious that a new cronjob needs to be applied #2101

Kimmax opened this issue Jan 17, 2018 · 2 comments
Assignees
Labels
feature Adding new functionality

Comments

@Kimmax
Copy link

Kimmax commented Jan 17, 2018

Adding a new cronjob via System -> Settings -> Cron does not automagically write it to crontab. This behavior could be miss-leading, since the button on the "Add pane" says "Save Changes".
We should either apply the changed cronjob immediately or make it really obvious that changed / new cronjobs need to be applied using the "Apply" button. Right now it looks like the button serves a reload or should be used when changing the "Enabled" checkbox

@Kimmax Kimmax changed the title Make it obvious that a new cron job needs to be applied Make it obvious that a new cronjob needs to be applied Jan 17, 2018
@Kimmax
Copy link
Author

Kimmax commented Jan 17, 2018

From IRC:

Kimmax: how about we pull in the "Configuration changed" notification from the fw?
Kimmax: The cronjob configuration has been changed.
Kimmax: You must apply the changes in order for them to take effect.
Kimmax: with the apply button right next to it
fitch: there is no unified implementation of that, which means we need to clutter every MVC page
fitch: we could show in JS maybe, but the state then is not persistent if you reload the page
Kimmax: adding that the apply button is necessary on the page as description or something should do the job for starters

@monreal
Copy link

monreal commented Nov 15, 2018

Thanks... I ran into this myself today and never noticed the apply button :(

@fichtner fichtner added the help wanted Contributor missing / timeout label Dec 30, 2018
@AdSchellevis AdSchellevis self-assigned this Mar 16, 2019
@AdSchellevis AdSchellevis added feature Adding new functionality and removed help wanted Contributor missing / timeout labels Mar 16, 2019
EugenMayer pushed a commit to KontextWork/opnsense_core that referenced this issue Jul 22, 2019
EugenMayer pushed a commit to KontextWork/opnsense_core that referenced this issue Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

No branches or pull requests

4 participants