firewall: put category filter selection on top of the list/screen

[jodelkoenig]

Hi,

would it be possible to move the field to set the filter for rule maintenance on top of the list/screen rather than at the bottom? It'll be great to just select the filter and maintain filter specific rules right away. Rather than scrolling all the way down, set filter, and scrolling all the way up again after a filter has been applied.

Thanx

[AdSchellevis]

@jodelkoenig you mean the category filter?

[jodelkoenig]

Indeed. The category filter :)

While I was thinking about it. It might make sense to put the whole section on top of the list. Meaning the line with the category filter as well as the buttons on the right (Move selected rules to end / Delete selected rules / Add new rule).

The legend should remain at the bottom.

[jodelkoenig]

One more thing, related to category filer:

It'll be great if a selection would survive the switch between interfaces. With 18.1 this is no longer the case. With the latest 17.x the selection was still valid, even if I changed the - via tab - from LAN to OpenVPN or so.

Thanks :)

[AdSchellevis]

ok, this is work in progress. ac4f5a1 fixes the "sticky" categories like it was, but creates issues in the menu system (matching).

To be continued...

[AdSchellevis]

Functional it would indeed be better to move the filter to the top of the page, optical it probably looks a bit better on the bottom.

I'm not sure this is the best version, but can you try the commits in this issue?

opnsense-patch ac4f5a1 5bc9fdf 0752629

[fichtner]

What if you put the drop down where the "Add xxx" buttons would be?

[fichtner]

[jodelkoenig]

I like your idea, fichtner. This looks much cleaner.

Thanks AdSchellevis. For both items. Category Filter at the top of the page and persistency of filter cross interface pages.

[AdSchellevis]

@fichtner better indeed, shall I change it accordingly

[fichtner]

yes please, I only fiddled with the browser's DOM

[AdSchellevis]

it was a bit of fiddling, but this should be it

[fichtner]

Very nice, thanks!

[jodelkoenig]

Indeed. Thanks a lot! Cool :)