Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewall: alias nesting vs. geoip #2199

Closed
fichtner opened this issue Feb 13, 2018 · 2 comments
Closed

firewall: alias nesting vs. geoip #2199

fichtner opened this issue Feb 13, 2018 · 2 comments
Assignees
Labels
cleanup Low impact changes

Comments

@fichtner
Copy link
Member

Adding a GeoIP alias "CH" and selecting "Switzerland" will make the alias fail to fetch any data.

This changed from 17.7 to 18.1 according to https://forum.opnsense.org/index.php?topic=7078.msg32856#msg32856

Do we add better validation or can we reenable this behaviour?

@fichtner fichtner added the cleanup Low impact changes label Feb 13, 2018
@fichtner fichtner added this to the 18.7 milestone Feb 13, 2018
@AdSchellevis
Copy link
Member

ok, this should work, cdae884 makes sure we don't skip resolving when the content equals our alias name.

Only downside is that when someone defines an alias "CH" with static content and has an alias containing both "CH" and "NL" the static alias is preferred.

@fichtner
Copy link
Member Author

Works, static preference sounds good. ❤️

fichtner pushed a commit that referenced this issue Feb 16, 2018
@fichtner fichtner removed this from the 18.7 milestone Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Low impact changes
Development

No branches or pull requests

2 participants