-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS and domain options for DHCPv6 and Router Advertisements, multiple issues #2336
Comments
Looks like this was introduced in 607d8ec.
|
Where is a reference to IPv4-only code 95 and 119 ? |
|
Doesn't domain-search-list collide with dhcp6.domain-search and we should use to set the former domain-search-list servers as dhcp6.domain-search if set or use the domain name like DNSSL? |
|
Hi Franco, Thanks for looking into this. RDNSS and DNSSL seem to be solid now! I can't reproduce the bugs after applying the patches. Regarding DHCP options: "LDAP" (95) and "Domain Search" (119) can be found in IANA's DHCPv4 options list: https://www.iana.org/assignments/bootp-dhcp-parameters Regarding dhcp6.domain-search: Could you clarify? I don't see the conflict. It should look like this: Cheers, |
|
Hi @maurice-w, Thank you for your help, it's tremendously useful! ❤️
Could you also double-check the previous cleanup for avoiding unconditional addition of dhcp6.name-servers discussed in the forum? 5e41585 Cheers, |
|
Now for the complicated part: "Domain search list" exists in the services_dhcpv6.php page, should this not be merged with the domain-name -> dhcp6.domain-search transition and follow a similar DNSSL logic: system domain if no custom servers defined? And for services_dhcpv6_edit.php do we also want "Domain search list" ? |
|
@maurice-w dod you have time to check these yet? I've queued up what we have for the upcoming 18.1.9, but there are still 2 open issues. |
|
@maurice-w some things are still open but everything else has been shipped already. happy to finish this up with your help. just let me know when you have time. |
|
@maurice-w ping :) |
|
closing until further feedback is given |
|
I recently noticed that the Domain Search List option is still missing in DHCPv6 replies. I rediscovered this old issue and created a pull request which should fix it.
Yes, it should.
Probably. We definitely don't want the Domain name option which is currently there. It simply doesn't exist in DHCPv6. |
The "domain-search" option in dhcpdv6.conf must be prefixed with "dhcp6". This fixes one of the issues from #2336 which are still open.
|
Im not able to trace back what we were discussing back then: dhcp6.domain-search looks ok now and domain-name should be generally removed. Am I missing something else? |
I created another pull request, please double check. |
Parameters in
dhcpdv6.conf, configured viaservices_dhcpv6.phpdomain-nameparameter, both as a global option (system domain) as well as a subnet-specific option (Domain name field). However, this is a DHCPv4 option and is ignored by dhcpd6. DHCPv6 uses thedhcp6.domain-searchoption only.1.1 The global
domain-nameoption (set to the system domain) should be renamed todhcp6.domain-search.1.2 The Domain name field should be removed from
services_dhcpv6.php.1.3 The Domain search list field should set the subnet-specific
dhcp6.domain-searchoption. Currently it sets thedomain-searchoption (which is ignored by dhcpd6 because it's a DHCPv4 option).option ldap-server code 95 = text;option domain-search-list code 119 = text;Reference (ISC DHCP 4.3 Man pages):
https://www.isc.org/wp-content/uploads/2017/08/dhcp43.html
https://www.isc.org/wp-content/uploads/2017/08/dhcp43options.html
Parameters in
radvd.conf, configured viaservices_router_advertisements.php1.1 If addresses are entered into the DNS servers fields, the
RDNSSoption is missing. It should be set to the specified addresses.1.2 If the DNS servers fields are left blank and Unbound is disabled, the
RDNSSoption is missing. It should be set to the IPv6 DNS servers configured viasystem_general.php.1.3 Enabling Use the DNS settings of the DHCPv6 server has no effect. It should set
RDNSSto the DNS servers configured viaservices_dhcpv6.php.2.1 The Domain search list field is supposed to set
DNSSLto the specified domains, but has no effect.DNSSLis always set to the system domain.2.2 If a Domain name(!) is specified via
services_dhcpv6.php(!),DNSSLis set to this domain. This should... not happen.I hope that's all. Tested with OPNsense 18.1.5, but these issues are not new. A domain and two IPv6 DNS servers are configured via
system_general.php. The LAN interface has a static IPv6 address, Router Advertisements are set to Assisted and the DHCPv6 server is enabled.The text was updated successfully, but these errors were encountered: