Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system: remove legacy notifications with monit alternatives #2408

Closed
lopsch opened this issue May 16, 2018 · 4 comments
Closed

system: remove legacy notifications with monit alternatives #2408

lopsch opened this issue May 16, 2018 · 4 comments
Assignees
Labels
cleanup Low impact changes
Milestone

Comments

@lopsch
Copy link

lopsch commented May 16, 2018

The actual integration for growl notifications is using the UDP:9887 protocol. This seems to be superseded by the GNTP which uses TCP:23053.

There is already a usable version in pfSense which uses Net_Growl. As far as I can see Net_Growl is available in ports.

As I'm not into PHP I just tried to apply the patch und download Net_Growl into the include directory for testing. I came as far as trying to send a message where it bails out not having mbstring available.

So I assume the packages Net_Growl depends on are not available at all:

  • mbstring extension
  • pcre extension
  • SPL extension
  • mcrypt extension (optional)

I would build a new image including the patches, Net_Growl and its dependencies for testing myself but to be honest I don't know where all the knobs are that I need to turn.

If someone could point me in the right direction and there is interest in an integration update I could try to contribute a PR.

Best regards and sorry if the issue is not correct/missing information.

@fichtner
Copy link
Member

Hi @lopsch,

The current notification framework is scheduled for a full removal in 18.7. We already imported Monit into the core package for this reason. I don't see this code going anywhere because of it. Ok?

Cheers,
Franco

@fichtner fichtner added the cleanup Low impact changes label May 17, 2018
@fichtner fichtner self-assigned this May 17, 2018
@fichtner fichtner added this to the 18.7 milestone May 17, 2018
@lopsch
Copy link
Author

lopsch commented May 17, 2018

Hi @fichtner,

thanks for the clarification. Will there be similar notification options through monit?

Best regards

@fichtner
Copy link
Member

Sorry for the delay! Monit is fully customizable, e.g. https://mmonit.com/wiki/MMonit/PushoverNotification

@fichtner fichtner modified the milestones: 18.7, 19.1 Jul 15, 2018
@fichtner fichtner changed the title Update growl integration for notifications system: remove legacy notifications with monit alternatives Sep 28, 2018
@fichtner
Copy link
Member

fichtner commented Nov 16, 2018

Closing in favour of #2919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Low impact changes
Development

No branches or pull requests

2 participants