Reference to alias object in NAT rule is lost after rename

[kendlbro]

If a NAT rule refers to an alias as source address and then the same alias is renamed, the reference in the NAT rule is not updated to the new alias name. As a result the NAT rule does not work anymore.

[fichtner]

@PhilippKendlbacher even with the fix from #1711 ?

[kendlbro]

I am running version 18.1.9 which is the latest "production" version.

[fichtner]

Please try ef51960 which is part of tomorrow's 18.1.10:

# opnsense-patch ef519606

Cheers,
Franco

[kendlbro]

I am sorry but an upgrade to 18.1.10 did not solve the problem.
When i rename the alias, the source address changes like this:

This was before renaming the alias:

Thanks,
Philipp

[fichtner]

No worries, let's see if we can find this :)

[ruffy91]

The issue is still present in 18.7.4 and 18.7.5_1.
After renaming an Outbound NAT rule no longer points to the alias but it gets replaced with a host with the name of the alias before renaming.

Will this be fixed with the new Alias API?

[AdSchellevis]

fixed with the new api enabled aliases. (checked source/destination/target on my install)

ref:

core/src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php

Lines 60 to 64 in 5d49c6a

	$sources[] = array(array('nat', 'outbound', 'rule'), array('source', 'network'));
	$sources[] = array(array('nat', 'outbound', 'rule'), array('sourceport'));
	$sources[] = array(array('nat', 'outbound', 'rule'), array('destination', 'address'));
	$sources[] = array(array('nat', 'outbound', 'rule'), array('dstport'));
	$sources[] = array(array('nat', 'outbound', 'rule'), array('target'));

[FrankWeis]

I have just had this again in 19.7.3.
Had an alias, used it in a NAT rule. Edited and renamed the alias for clarity, and after wondering why my NAT stopped working I came to find it dangling.