Knob for vlanhwfilter disable in system settings

[fichtner]

via: https://forum.opnsense.org/index.php?topic=896.0

[AdSchellevis]

Is this what your looking for 2a3a6a1 ?

An option to set all technical parameters for an interface is probably not the best thing to do in the legacy code, maybe more something for the wishlist for future releases? (to prevent too much changes in legacy code and possible transition problems between versions).

[fichtner]

This is exactly the amount of code needed for this to be solved short-term. So, yes, Long-term the interfaces in the new GUI need a better system. :)

As for the patch: yes, thank you, almost. There separate hardware code that sets vlanhwfilter unconditionally on a vlan though:

core/src/etc/inc/interfaces.inc

Line 266 in 2a3a6a1

legacy_interface_flags($if, 'vlanhwtag vlanmtu vlanhwfilter');

[AdSchellevis]

No problem, will look at that in an hour or so.

[fichtner]

Awesome, thank you. :D

[AdSchellevis]

Your welcome.
I guess it makes most sense to disable all hw options when hwfilter is disabled.
Commit cd41d6b contains the fix.

[fichtner]

I tried to backport these changes, but for some reason it doesn't work. It seems to be a larger issue. I can't even unset the tags in ifconfig, at least for the e1000 driver I've tested so far.