Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wierd IPv6 issue when using PPPoE #2726

Closed
marjohn56 opened this issue Sep 16, 2018 · 8 comments
Closed

Wierd IPv6 issue when using PPPoE #2726

marjohn56 opened this issue Sep 16, 2018 · 8 comments
Assignees
Labels
bug Production bug
Milestone

Comments

@marjohn56
Copy link
Member

marjohn56 commented Sep 16, 2018

We noticed that if you save and apply the WAN interface, don't take it down - just save and apply then when the interface comes back up there is no IPv6 address on the PPPoE interface. I think this is because the PPPoE interface is not ready for it. Sort of proved this by putting a sleep(5) ( maybe a bit long ) in the case 'ppp': call where it's setup for V4.

Interfaces.inc Lines 211 on.

switch ($wancfg['ipaddr']) {
case 'dhcp':
interface_dhcp_configure($interface);
break;
case 'pppoe':
case 'l2tp':
case 'pptp':
case 'ppp':
interface_ppps_configure($interface);
sleep(5);
break;
default:
/* XXX: Kludge for now related to #3280 */
if (!in_array($tunnelif, array("gif", "gre", "ovp"))) {
if (is_ipaddrv4($wancfg['ipaddr']) && $wancfg['subnet'] <> "") {
legacy_interface_setaddress($realif, "{$wancfg['ipaddr']}/{$wancfg['subnet']}");
}
}
break;
}

Very likely not the way to fix this, but I wonder if this is causing some of the odd v6 behaviour sometimes seen on the forum.

@marjohn56
Copy link
Member Author

Have a little free time to take a look at this. It appears it only happens if you have a static v6 with PPPoE on v4. I think if you are using dhcp6c the natural sequence of things allows that to work, but with static v6 it appears it's trying to add the v6 address before the interface is ready. I know it fixes it using a generic sleep(5) before applying the static, I'll reduce that until it no longer works then increase it and also add a catch so that it only sleeps if dhcp4 is pppoe and v6 is static.

@fichtner
Copy link
Member

is that use ipv4 connectivity (em/igb) or static ipv6 on top of the pppoe itself?

@marjohn56
Copy link
Member Author

Use IPv4 connectivity is checked, as it's using the PPPoE link.

@fichtner fichtner added the bug Production bug label Sep 21, 2018
@fichtner fichtner added this to the 19.1 milestone Sep 21, 2018
@fichtner
Copy link
Member

@marjohn56 noted via #2736

That bits OK, but the dev version has something amiss in the firewall, it was not allowing any of my rules for my servers, everything was hitting the default deny.

Did you solve this or potentially still happening? There are a few minor firewalling changes, but nothing drastic that would force this.

@marjohn56
Copy link
Member Author

No, I had to switch back to production due to complete lack of email coming through, SWMBO was muttering. I'll try and have another look when I can.

@fichtner
Copy link
Member

Alias issue solved in -devel

@marjohn56
Copy link
Member Author

Confirmed. Running live unit with 11.2 at 19.1b, all good.

@fichtner
Copy link
Member

fichtner commented Oct 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Production bug
Development

No branches or pull requests

2 participants