-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firewall log widget edit - Show error #2747
Comments
|
using 6 columns! |
|
ouch. I'll fix this... |
fichtner
added a commit
that referenced
this issue
Oct 23, 2018
The initial design of the options could have been better. Too much smarts for little benefit. Break "All" interface option while here, we shouldn't use a text that could be an interface. Also, remove the table widget layout fix since we have text-wrap. But ironically enough Firefox doesn't care about text-wrap so we are back to overflowing the container on long words. It's still the same issue: too little space for displaying what you want to display. I'm not going to work on this anymore.
fichtner
added a commit
to opnsense/plugins
that referenced
this issue
Oct 23, 2018
|
@fichtner
I will make a pr for cicada and tukan later on today too.
Regards,
Rene
Dienstag, 23. Oktober 2018, 08:07 +0200 von notifications@github.com <notifications@github.com>:
…Closed #2747 .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub , or mute the thread .
|
|
Hi René, already done: opnsense/plugins@01386a2e6e2e |
|
👍 that was fast :-) thx |
fichtner
added a commit
that referenced
this issue
Oct 23, 2018
The initial design of the options could have been better. Too much smarts for little benefit. Break "All" interface option while here, we shouldn't use a text that could be an interface. Also, remove the table widget layout fix since we have text-wrap. But ironically enough Firefox doesn't care about text-wrap so we are back to overflowing the container on long words. It's still the same issue: too little space for displaying what you want to display. I'm not going to work on this anymore. (cherry picked from commit 5737462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: