Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Auto-Config rules order of proxy entries #2979

Closed
Kimotu opened this issue Nov 28, 2018 · 10 comments · Fixed by #3358
Closed

Proxy Auto-Config rules order of proxy entries #2979

Kimotu opened this issue Nov 28, 2018 · 10 comments · Fixed by #3358
Assignees
Labels
feature Adding new functionality
Milestone

Comments

@Kimotu
Copy link

Kimotu commented Nov 28, 2018

I created two proxy entries and a direct one.

When I use the rules to combine matches and proxies, my proxy order gets messed up when saving the rule.

I want: proxy1, proxy2, direct

When I save, it gets reversed to direct, proxy2, proxy1. The direct "proxy" should act as fall-back. The order is not alphabetical. I tried to name them A, B, C and order is still, C, B, A. I even added them in reverse order, but sort criteria must be something else, even not ip address because proxy1 is lower ip than proxy2.

The resulting wpad.dat creates the saved order which is wrong. The order should be kept the way you add the proxies.

@fabianfrz
Copy link
Member

(FYI) @fichtner @AdSchellevis this is a model relation field and the usual GUI component (select_multiple). Maybe there is something you want to do in the used scripts but I don't think there is something we can do.

@mimugmail
Copy link
Member

Is this sorting related? I did workaround this in frr/bgp with extra priority field

@fabianfrz
Copy link
Member

@mimugmail yes. If this ticket is true, the content order of the UUIDs in for modelrelationfield are is not the same as in the input field. This is very likely a problem that the frontend component sends an incorrect order.

@fichtner
Copy link
Member

isn't this the same issue as always? expecting order when we don't pledge order in the model-relation selection?

@fabianfrz
Copy link
Member

maybe yes, some kind of an order field can be added but I think that users expect it to be stored in the order they enter data. Maybe an UX issue.

I never planned that to be ordered because it is designed like "use A and if it fails, use B".

@mimugmail
Copy link
Member

Yep, but as always there's one guy using it the way you never thought of.

This is how I did it:
https://github.com/opnsense/plugins/blob/master/net/frr/src/opnsense/service/templates/OPNsense/Quagga/bgpd.conf#L172

@Kimotu
Copy link
Author

Kimotu commented Nov 28, 2018 via email

@fichtner
Copy link
Member

Sorry for the confusion. We're not talking about PAC.

@Kimotu
Copy link
Author

Kimotu commented Mar 18, 2019

Any progress this subject? Maybe you can do the sorting in backend by name? Then I could use prefixes 01_proxy, 02_proxy, 03_direct to set order?

@fichtner
Copy link
Member

Sort order was introduced in recent 19.1.x versions for HAProxy in particular. Maybe it can be used here too. @fabianfrz will be back next week and likely look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

Successfully merging a pull request may close this issue.

4 participants