interfaces: squelch warnings during parse

[fichtner]

[09-Dec-2018 11:44:56 Europe/Athens] PHP Warning:  in_array() expects parameter 2 to be array, null given in /usr/local/etc/inc/interfaces.lib.inc on line 359
[09-Dec-2018 11:44:56 Europe/Athens] PHP Warning:  in_array() expects parameter 2 to be array, null given in /usr/local/etc/inc/interfaces.lib.inc on line 359
[09-Dec-2018 11:44:56 Europe/Athens] PHP Warning:  in_array() expects parameter 2 to be array, null given in /usr/local/etc/inc/interfaces.lib.inc on line 360
[09-Dec-2018 11:44:56 Europe/Athens] PHP Warning:  in_array() expects parameter 2 to be array, null given in /usr/local/etc/inc/interfaces.lib.inc on line 360
[09-Dec-2018 11:44:56 Europe/Athens] PHP Warning:  in_array() expects parameter 2 to be array, null given in /usr/local/etc/inc/interfaces.lib.inc on line 361
[09-Dec-2018 11:44:56 Europe/Athens] PHP Warning:  in_array() expects parameter 2 to be array, null given in /usr/local/etc/inc/interfaces.lib.inc on line 361
[09-Dec-2018 11:44:56 Europe/Athens] PHP Warning:  in_array() expects parameter 2 to be array, null given in /usr/local/etc/inc/interfaces.lib.inc on line 362

via https://forum.opnsense.org/index.php?topic=10614.0

[AdSchellevis]

This shouldn't happen, 'option' from the error here
https://github.com/opnsense/core/blob/18.7.8/src/etc/inc/interfaces.lib.inc#L359

Is always initialised here:

core/src/etc/inc/interfaces.lib.inc

Line 234 in c5acb41

$result[$current_interface]["options"] = array();

Maybe a broken patch installed?

[fabianfrz]

@AdSchellevis except in probably one case: the interface did not exist yet when ifconfig was called…

[AdSchellevis]

@fabianfrz your right, it's not legacy_interfaces_details(), but legacy_interface_details() that's returning an empty result set.

[AdSchellevis]

@fichtner 8b73d9e should be the issue here :)

[fichtner]

Aha, nice catch. I changed the behaviour slightly in 7fe52b2 to always return an empty array because I thought that would be safer than doing call_this_one()['now_get_this_magic_offset'] that PHP seems to be returning with null silently(*).

(*) until it doesn't in a future PHP upgrade