Auto-complete of aliases no more working after update to 18.7.9

[myksto71]

After a update the last few weeks we see that autocomplete of aliases are no more working.
I noticed that a similar issue was opened more than 2 years ago: #372

What we have:

• alias foo
  -- type hosts
  -- content 1.2.3.4

Now we add a new alias:

• alias bar
  -- type hosts
  -- content: start typing foo, but no autocomplete happens (uppercase and lowercase).

Best Regards,
Michele.

[AdSchellevis]

We seem to have missed the alias autocomplete function in the new alias system, with the new tokeniser it might be more difficult to integrate, we have to look into it.

I'll put it on the list of things todo, we should try to bring it back.

[myksto71]

Thank you very much for your quick reply.
I really hope you can bring that function back and hope you will do it soon! ;)

Thanks you again and best regards.

Michele.

[AdSchellevis]

This ab4e900 should fix the issue, although there is still a minor glitch in validation (ideally it shouldn't be possible to mix port and other types, but since it won't render defective configs I think it's good enough for now).

[myksto71]

This ab4e900 should fix the issue, although there is still a minor glitch in validation (ideally it shouldn't be possible to mix port and other types, but since it won't render defective configs I think it's good enough for now).

Hi AdSchellevis.
Hi applied the patch and it seems to have solved to problem.
I have one question even thoght it may be silly: when any other update/upgrade will be applied we should apply the patch again or it will be included in the update/upgrade itself?

I really thank you very much for the job.

Best reagrds,
Michele.

[AdSchellevis]

Hi Michele,

Thanks for confirming.
We'll try to add the patch to the next release, since the impact should be quite low.
Otherwise you should indeed patch again after upgrade, which you can easily do with our opnsense-patch utility.

Best regards,

Ad

[fichtner]

Will be in 18.7.10.