ui: regression in single host or network subnet select (bootstrap select)

[fichtner]

The subnet select will not give any options other than the default. See e.g. src/dst in firewall outbound NAT edit.

maybe due to #2848

via: https://forum.opnsense.org/index.php?topic=11274.0

[AdSchellevis]

2af9202 fixes the behaviour, the layout however is still flawed.

@MichaelDeciso since your commit broke this, would you be so kind to fix the layout issues in the legacy code (for example in firewall_nat_edit.php).

In 18.7 this looks like this:

Now it looks like this:

It's likely a css issue in the supplied stylesheet #2939

[MichaelDeciso]

I have checked the Bootstrap documentation and the selectpicker CSS, and the problem is that the .input-group-btn class is not set here (but in most other places we use stuff like this, the class is set). This is compulsory according to the Bootstrap docs, and selectpicker 1.12 specifically looks for it. When I set the class, it looks and behaves correctly.

Will open a PR once I'm sure it works correctly and I haven't missed any other occurrences.

[MichaelDeciso]

#3151

[AdSchellevis]

@MichaelDeciso ok, looks good, thanks!