Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configd: additional features for plugins #329

Closed
fichtner opened this issue Aug 19, 2015 · 6 comments
Closed

configd: additional features for plugins #329

fichtner opened this issue Aug 19, 2015 · 6 comments
Assignees
@AdSchellevis
Labels
feature Adding new functionality
Milestone
16.1

Comments

@fichtner
Copy link
Member

o hotplug support for actions
o fail when reloading a missing template
o template revoke for plugin deinstall
o template trigger on bootup
@fichtner fichtner added the feature Adding new functionality label Aug 19, 2015
@fichtner fichtner added this to the 16.1 milestone Aug 19, 2015
AdSchellevis added a commit that referenced this issue Dec 1, 2015
@AdSchellevis
(init) template trigger on bootup, #329
428591c
@AdSchellevis
Copy link
Member

"template trigger on bootup" is in.
The other subjects very likely won't get in soon:

  • hotplug is a nice to have for now
  • not sure what "fail when reloading a missing template" should do
  • the deinstall is probably better to leave it at the plugin deinstall script, targets may contain patterns which make this a bit tricky.

@fichtner
Copy link
Member Author

fichtner commented Dec 1, 2015

Okay, I'm happy with "fail when reloading a missing template", if you tell it to reload "fooo", it will say "ok" and not return an error. Makes it hard to catch typos in plugins early.

@AdSchellevis
Copy link
Member

Ah, you want an error if no files where generated?

@fichtner
Copy link
Member Author

fichtner commented Dec 1, 2015

No, an error when a template is invoked that does not exist.

AdSchellevis added a commit that referenced this issue Dec 1, 2015
@AdSchellevis
(configd) template generation, return ERR when template not found. see …
196da2b 
…#329
@AdSchellevis
Copy link
Member

fixed.

@fichtner
Copy link
Member Author

fichtner commented Dec 1, 2015

Brilliant, closing.

@fichtner fichtner closed this as completed Dec 1, 2015
AdSchellevis added a commit that referenced this issue Dec 7, 2015
@AdSchellevis @fichtner
(init) template trigger on bootup, #329
84fe688 
(cherry picked from commit 428591c)
AdSchellevis added a commit that referenced this issue Dec 7, 2015
@AdSchellevis @fichtner
(configd) template generation, return ERR when template not found. see …
4fc2f8c 
…#329

(cherry picked from commit 196da2b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdSchellevis AdSchellevis

Labels
feature Adding new functionality
Milestone
16.1
Development

No branches or pull requests
2 participants
@fichtner @AdSchellevis