Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVPN client export custom config text area not showing multiple lines on Firefox #3825

Closed
muchachagrande opened this issue Nov 21, 2019 · 5 comments
Assignees
Labels
cleanup Low impact changes
Milestone

Comments

@muchachagrande
Copy link

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[yes] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md

[yes] I have searched the existing issues and I'm convinced that mine is new.

Describe the bug
In OpenVPN > Client Export there is a text field to add a custom config that will be returned in
the output file.
When I add 3 commands on 3 different lines to this field, all 3 commands are shown in one line separated with spaces, when there should be seen as 3 consecutive lines of text.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'VPN > OpenVPN > Client Export'
  2. Click on 'Custom config text field'
  3. Write some line of text and press Enter to continue writing on the next line
  4. The problem is that the new line is shown as a space so the following line is shown just next to the previous one, so all entered commands are shown on one long line

Expected behavior
The various entered lines of custom config should be seen one on multiple lines of text.

Screenshots
This is how I see 3 command:

fragment 1250 mssfix 1250 tun-mtu 1500

This is how it should be seen:

fragment 1250
mssfix 1250
tun-mtu 1500

OPNsense 19.7.6-amd64
FreeBSD 11.2-RELEASE-p14-HBSD
OpenSSL 1.0.2t 10 Sep 2019
Running on VMWare ESXi 6.7

@AdSchellevis
Copy link
Member

I can't reproduce this on my end (using Chrome):
image

The generated config file shows multiple lines as well.

Maybe a browser issue?

@AdSchellevis AdSchellevis added the support Community support label Nov 21, 2019
@muchachagrande
Copy link
Author

muchachagrande commented Nov 21, 2019

You are right, I'm using Firefox. I've just tested with Chrome and it shows fine.
Exported config shows multiple lines on both browsers.
May be it can be fixed by using the same textbox attributes that are being used in Advanced Config of the OpenVPN configuration, that is being viewed correctly on Firefox.

imagen

@AdSchellevis
Copy link
Member

Its' not the input itself, for some reason the content seems to be cleansed in firefox.
image
image

@AdSchellevis
Copy link
Member

ok, looks like this https://bugzilla.mozilla.org/show_bug.cgi?id=1137650 should be fixed with fde54d9 (opnsense-patch fde54d9 on a console)

@AdSchellevis AdSchellevis added cleanup Low impact changes and removed support Community support labels Nov 21, 2019
@AdSchellevis AdSchellevis self-assigned this Nov 21, 2019
@muchachagrande
Copy link
Author

@AdSchellevis ... tested and now it's ok... thank you

imagen

@muchachagrande muchachagrande changed the title OpenVPN client export custom config text area not showing multiple lines OpenVPN client export custom config text area not showing multiple lines on Firefox Nov 21, 2019
@fichtner fichtner added this to the 20.1 milestone Nov 21, 2019
fichtner pushed a commit that referenced this issue Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Low impact changes
Development

No branches or pull requests

3 participants