Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAC address database outdated #3883

Closed
xpac1985 opened this issue Jan 13, 2020 · 9 comments
Closed

MAC address database outdated #3883

xpac1985 opened this issue Jan 13, 2020 · 9 comments
Labels
help wanted Contributor missing / timeout

Comments

@xpac1985
Copy link

Describe the bug
The MAC address database used to get e.g. the hardware vendor from a mac address in the DHCP -> Leases page is pretty outdated.
According to this forum post, OPNsense uses the netaddr Python lib, which hasn't been updated since January 2017 and has no self-update mechanism built in. From the issues in their Github project, this has been mentioned multiple times, but it seems to be rather dead.

To Reproduce

  1. Go to Services -> DHCPv4 -> Leases (status_dhcp_leases.php)
  2. Have any recent device on your network
  3. See vendor names only for older hardware.

Expected behavior
Show vendor names for all MAC addresses.

Additional context
Maybe using the mac-vendor-lookup Python library is a valid replacement:
https://pypi.org/project/mac-vendor-lookup/

@fichtner fichtner added the help wanted Contributor missing / timeout label Jan 13, 2020
@AdSchellevis
Copy link
Member

It's probably better to see how netaddr/netaddr#189 pins out, the PR is only a couple of months old, which isn't unusual for these kind of projects, migrating to something else in the hope that it won't get abandoned has risks of its own.

Another library to only fetch http://standards-oui.ieee.org/oui.txt is something I would rather prevent from happening.

@xpac1985
Copy link
Author

xpac1985 commented Feb 3, 2020

Yeah, I see the reasoning behind this. I just pointed to that lib because it allows to automatically pull the list for updates, while netaddr has it statically bundled and you'll have to wait for another release to be available for up to date data. It's not super important though, so I don't wanna cause a lotta work. ;-)

@brianmaissy
Copy link

Hey, I saw that you referenced my PR to netaddr. I'm trying to get it merged, but the maintainer isn't being so responsive. If it continues this way at some point I will also give up, and then I might fork the project and continue maintaining it (or at least updating the databases) myself. We'll be in touch.

@brianmaissy
Copy link

Sorry it's been a while and I haven't been in touch. We ended up vendoring it, but it looks like the project might be back to active maintenance.

@AdSchellevis
Copy link
Member

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.

@ChriZ982
Copy link

ChriZ982 commented Jan 23, 2023

Hello everyone,

it seems that the MAC database is outdated again. The netaddr repository has not seen any contributions since 2 years:

grafik

I think it would be best to revisit this issue and download the MAC database regularly: #5205

@AdSchellevis please reopen this issue. Thanks!

Best regards,
Chris

@AdSchellevis
Copy link
Member

@ChriZ982 are you planning to work on it? reopening doesn't really make sense if there's no owner for the issue

@ChriZ982
Copy link

@AdSchellevis Thanks for your fast response. I was hoping that a maintainer could take a look at it, because I am not familiar with the project. If that is not possible, I could also go through the Development Manual and try to implement it myself.

@AdSchellevis
Copy link
Member

@ChriZ982 we don't have plans to change this at the moment, it would be more logical to fix this upstream to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributor missing / timeout
Development

No branches or pull requests

5 participants