Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remaining submit inputs vs. gettext issues #431

Closed
fichtner opened this issue Oct 13, 2015 · 1 comment
Closed

fix remaining submit inputs vs. gettext issues #431

fichtner opened this issue Oct 13, 2015 · 1 comment
Assignees
@fichtner
Labels
cleanup Low impact changes
Milestone
16.7

Comments

@fichtner
Copy link
Member 

# git grep "<input.*type=[\"']submit[\"'].*gettext" | wc -l
     151
@fichtner fichtner added the bug Production bug label Oct 13, 2015
@fichtner fichtner self-assigned this Oct 13, 2015
@fichtner fichtner added this to the 16.1 milestone Oct 13, 2015
@fichtner fichtner mentioned this issue Oct 18, 2015
Closed
fichtner added a commit that referenced this issue Dec 22, 2015
@fichtner
firewall: fix save in translation mode closes #546 #547
8f5c812 
This is part of #431, right fix is to use <button/> instead.  We
don't want to extend the code to fix this, it'll introduce more
bugs and strangeness later.  Still a lot to do there, any help is
welcome, the conversion is pretty simple.
@fichtner fichtner mentioned this issue Dec 22, 2015
Closed
fichtner added a commit that referenced this issue Dec 22, 2015
@fichtner
firewall: fix save in translation mode closes #546 #547
209a4fa 
This is part of #431, right fix is to use <button/> instead.  We
don't want to extend the code to fix this, it'll introduce more
bugs and strangeness later.  Still a lot to do there, any help is
welcome, the conversion is pretty simple.
@fichtner fichtner modified the milestones: 16.7, 16.1 Jan 9, 2016
fichtner added a commit that referenced this issue Jan 10, 2016
@fichtner
www: fix more apply vs. translation foo #431
b5d135d
fichtner added a commit that referenced this issue Jan 11, 2016
@fichtner
www: fix more apply vs. translation foo #431
c7b8861 
(cherry picked from commit b5d135d)
@fichtner fichtner added cleanup Low impact changes and removed bug Production bug labels Feb 16, 2016
@fichtner fichtner changed the title fix legacy code madness with submit inputs and gettext value obfuscation fix submit inputs vs. gettext issues Feb 16, 2016
@fichtner fichtner changed the title fix submit inputs vs. gettext issues fix remaining submit inputs vs. gettext issues Feb 16, 2016
@fichtner
Copy link
Member Author

overcome by @AdSchellevis ! thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fichtner fichtner

Labels
cleanup Low impact changes
Milestone
16.7
Development

No branches or pull requests
1 participant
@fichtner