Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firewall/aliases: condense into one page #443

Closed
sjorge opened this issue Oct 23, 2015 · 6 comments
Closed

firewall/aliases: condense into one page #443

sjorge opened this issue Oct 23, 2015 · 6 comments
Assignees
@fichtner
Labels
cleanup Low impact changes
Milestone
16.7

Comments

@sjorge
Copy link
Contributor

sjorge commented Oct 23, 2015

e.g. on ip, default to hosts, on port default to port when clicking the add button
@fichtner
Copy link
Member

Maybe we can get rid of "faking" pages, the URL is the same anyway?

@fichtner fichtner reopened this Oct 23, 2015
@fichtner
Copy link
Member

Whoops, wrong button :D

@fichtner
Copy link
Member

I think I'm going to work that into the 16.1 menu changes, only one alias page and be done with it.

@fichtner fichtner added the feature Adding new functionality label Oct 23, 2015
@fichtner fichtner added this to the 16.1 milestone Oct 23, 2015
@fichtner fichtner self-assigned this Oct 23, 2015
@sjorge
Copy link
Contributor Author

sjorge commented Oct 23, 2015

sounds good to me.

@fichtner fichtner changed the title add alias does should default to the type of the page calling it firewall/aliases: condense into one page Oct 23, 2015
@fichtner
Copy link
Member

brilliant, cheers for the feedback :)

@fichtner fichtner modified the milestones: 16.7, 16.1 Feb 4, 2016
@fichtner fichtner added cleanup Low impact changes and removed feature Adding new functionality labels Feb 16, 2016
@fichtner
Copy link
Member

  • Network aliases edit allows comma-separated entries per entry
  • Import page only does networks, global description seeps into item description

fichtner added a commit that referenced this issue Apr 1, 2016
@fichtner
firewall: simplify and prettify alias pages #443
2e20c8d
@fichtner fichtner closed this as completed Apr 1, 2016
fichtner added a commit that referenced this issue Apr 1, 2016
@fichtner
firewall: simplify and prettify alias pages #443
2f32f45 
(cherry picked from commit 2e20c8d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fichtner fichtner

Labels
cleanup Low impact changes
Milestone
16.7
Development

No branches or pull requests
2 participants
@sjorge @fichtner