Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration-based menu parsing #508

Closed
fichtner opened this issue Dec 7, 2015 · 1 comment
Closed

Configuration-based menu parsing #508

fichtner opened this issue Dec 7, 2015 · 1 comment
Assignees
@AdSchellevis
Labels
feature Adding new functionality

Comments

@fichtner
Copy link
Member

fichtner commented Dec 7, 2015

The code currently slurps interfaces into the menu from the config, which is needed, but not very well carried out. Ideally a pluggable and descriptive function should be available that e.g. provides a config path that will be transformed into a menu item of some kind, maybe with a callback to the actual component (model).

Menu interaction is required by at least the following:

  • Assigned interfaces
  • Firewall disable
  • DNS forwarder/resolver
@fichtner fichtner added the feature Adding new functionality label Dec 7, 2015
@fichtner fichtner added this to the 16.1 milestone Dec 7, 2015
@fichtner fichtner mentioned this issue Jan 9, 2016
Closed
@fichtner fichtner modified the milestones: 16.7, 16.1 Jan 9, 2016
AdSchellevis added a commit that referenced this issue Mar 18, 2016
@AdSchellevis
(menu) add filter for menu items, creating space for #508
d537808 
Using this version, it will already be possible to "delete" (sub)menus from inherited structures, using the visibility="delete" tag on an item.
fichtner pushed a commit that referenced this issue Apr 3, 2016
@AdSchellevis @fichtner
(menu) add filter for menu items, creating space for #508
33c43ae 
Using this version, it will already be possible to "delete" (sub)menus from inherited structures, using the visibility="delete" tag on an item.

(cherry picked from commit d537808)
@fichtner fichtner modified the milestones: 17.1, 16.7 May 24, 2016
@fichtner fichtner modified the milestones: Future, 17.1 Dec 10, 2016
@fichtner
Copy link
Member Author

fichtner commented Mar 2, 2017

unnecessary wishlist item. we'll get there when we get there.

@fichtner fichtner closed this as completed Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdSchellevis AdSchellevis

Labels
feature Adding new functionality
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fichtner @AdSchellevis