Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn: prevent deletion if instance is assigned to an interface #5163

Closed
2 tasks done
fichtner opened this issue Aug 13, 2021 · 0 comments
Closed
2 tasks done

openvpn: prevent deletion if instance is assigned to an interface #5163

fichtner opened this issue Aug 13, 2021 · 0 comments
Assignees
Labels
cleanup Low impact changes
Milestone

Comments

@fichtner
Copy link
Member

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.

When starting an OpenVPN instance from scratch and deleting the old one the probable interface assignment is never cleared which call cause all sorts of "strange" issues similar to when a hardware interface would disappear.

Describe the solution you like

When deleting an OpenVPN instance (server or client) make sure that the device is not being used in an interface. If that is the case block the deletion until the assignment was modified or the interface deleted.

Describe alternatives you considered

N/A

Additional context

https://forum.opnsense.org/index.php?topic=24248.0

@fichtner fichtner added the cleanup Low impact changes label Aug 13, 2021
@fichtner fichtner added this to the 22.1 milestone Aug 13, 2021
@fichtner fichtner assigned fichtner and AdSchellevis and unassigned fichtner Aug 13, 2021
fichtner pushed a commit that referenced this issue Sep 21, 2021
…using new is_interface_assigned() funciton in utils.inc, implement check in openvpn client/server while here. closes #5163

(cherry picked from commit 3bd36b5)
oshogbo pushed a commit to DynFi/opnsense-core that referenced this issue Mar 3, 2022
…using new is_interface_assigned() funciton in utils.inc, implement check in openvpn client/server while here. closes opnsense/core#5163

(cherry picked from commit 3bd36b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Low impact changes
Development

No branches or pull requests

2 participants