Unbound: General: migrate to MVC

[fichtner]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.

Static pages need to be removed eventually. Services page offers opportunity for it and enables API handling of the functionality.

Describe the solution you like

Please move OPNsense.unboundplus to OPNsense.unbound while at it.

Describe alternatives you considered

N/A

Additional context

N/A

[swhite2]

Implemented in 5492d44

[fichtner]

Not so fast, the wizard needs a bit more attention now:

# git grep 'unbound->' src/wizard/
src/wizard/system.xml:                <bindstofield>unbound->enable</bindstofield>
src/wizard/system.xml:                <bindstofield>unbound->dnssec</bindstofield>

[fichtner]

The port can be empty but the model is set to required and a blank port will thus be filled out during migration. Also BlankDesc doesn't seem to do what it should.

[fichtner]

I fixed the BlankDesc via e42b8a3. However, it makes more sense to enforce the default since we migrate anyway and hardcoding "53" everywhere clutters the code. But I don't agree on enabling unbound on migration by default. Also we need to adjust src/etc/config.xml.sample accordingly. It still uses the old config layout.

[swhite2]

@fichtner How about ffc1c43? :)

[fichtner]

So far so good. What about spurious hint/blankdesc? And the default for model that unbound is enabled is also not advisable. It would worst case enable unbound on default port clashing with something else or preventing migration?

[fichtner]

The help text for port also needs attention./

[fichtner]

All done 👍