Skip to content

Firewall groups explicit ordering #6471

Closed

Description

@erlendk

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.

I would like to be able to set the internal priority between firewall groups in an explicit way, so that when an interface is a member of more than one group, the rules are applied in an order not determined by the name of the groups, but by their given priority.

Right now the priority between firewall groups seems to be based on the ascending alphabetical ordering between group names.

Describe the solution you like

In the "Firewall: Groups" page, I would like to be able to reorder groups. Possible solutions could be drag-and-drop or arrows to move groups up and down, or maybe a "Move selected groups after this group"-button, that would be more in line with the firewall rules page. The groups should (still) be listed in their applied order, and this should also be communicated on the page.

Describe alternatives you considered

N/A

Additional context

The experienced alphabetical ordering is also backed by this forum post.

Activity

  1. AdSchellevis commented on Apr 4, 2023

    @AdSchellevis
    Member

    It might be an idea to combine this with the MVC migration in #6385 and add a priority field, explicit choices are certainly better than assumptions.

  2. added this to the 23.7 milestone on Apr 4, 2023
  3. fichtner commented on Apr 4, 2023

    @fichtner
    Member

    In general this sounds sane, but I also think that this might be more work than worth it vs. prepending a priority to the name itself.

  4. AdSchellevis commented on Apr 4, 2023

    @AdSchellevis
    Member

    Let's keep it on the wishlist for now, we can remove it if the amount of work doesn't warrant the change later.

  5. AdSchellevis commented on Jul 3, 2023

    @AdSchellevis
    Member

    implemented in 8e197ff

  6. removed their assignment
    on Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

featureAdding new functionality

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions