-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale.en.canonical #144
Merged
Merged
Locale.en.canonical #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not certain if this is the eventual final location for the .pot files, but, they should certainly be bundled up neatly with the OPNsense "core" package, as they are for the OPNsense GUI itself- not the base OS. Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
executed via: $ git grep gettext >> src/share/locale/en/LC_MESSAGES/OPNsense.pot Now it's time to roll up the sleeves and get the english base done. (Still need to hook up the relevant gettext machinery...) Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
…tion. Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
If one of those bottles should happen to fall, 98 bottles of beer on the wall! Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Warning: This file does not represent the last month of changes in the OPNsense codebase, next step is to follow up with an update to changed lines. It is merely a first pass from-scratch dump from the source code. Another Warning: many lines still contain errors, based on relatively inconsistent use of gettext calls in the source code. There are many noted 'TODO' comments in the file, many of which in code which may just get ripped out soon- so keep track of current OPNsense core development efforts before you go too wild fixing something- it may be rewritten and your work would be wasted! Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
|
Saw this and like it, but would like to wait till Monday to merge. :) Thanks for your work! |
|
No rush! Also, if you want me to clean up, squash, or move the file location, just reject this PR with notes on how you want it and I'll clean things up to spec. Best, |
|
No need, looks clean enough. A bit of history is always good. Merged, cheers for this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi OPNsense and JP team:
Finished the first pass through the code, here's an English .pot file. Here's why I'm submitting this PR now:
https://forum.opnsense.org/index.php?topic=225.msg806#msg806locale
Next, I'm ripping through for changes in the source which would have changed these English strings in the last month.
Best,
.ike