Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale.en.canonical #144

Merged
merged 136 commits into from
Apr 20, 2015
Merged

Locale.en.canonical #144

merged 136 commits into from
Apr 20, 2015

Conversation

dotike
Copy link
Contributor

@dotike dotike commented Apr 18, 2015

Hi OPNsense and JP team:

Finished the first pass through the code, here's an English .pot file. Here's why I'm submitting this PR now:

  • This file should be parsable by gettext correctly, so I18N hacking can begin...
  • The location of this file (and the OPNsense locale/ directory) needs to be solidified, as was discussed here:
    https://forum.opnsense.org/index.php?topic=225.msg806#msg806locale
  • This file is extremely close for interested translators to copy and start working with...

Next, I'm ripping through for changes in the source which would have changed these English strings in the last month.

Best,
.ike

dotike added 30 commits April 9, 2015 16:12
I'm not certain if this is the eventual final location for the .pot files, but, they should certainly be bundled up neatly with the OPNsense "core" package, as they are for the OPNsense GUI itself- not the base OS.

Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
executed via:
$ git grep gettext >> src/share/locale/en/LC_MESSAGES/OPNsense.pot

Now it's time to roll up the sleeves and get the english base done.
(Still need to hook up the relevant gettext machinery...)

Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
…tion.

Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
If one of those bottles should happen to fall, 98 bottles of beer on the wall!

Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
Warning: This file does not represent the last month of changes in the OPNsense codebase, next step is to follow up with an update to changed lines.  It is merely a first pass from-scratch dump from the source code.

Another Warning: many lines still contain errors, based on relatively inconsistent use of gettext calls in the source code.

There are many noted 'TODO' comments in the file, many of which in code which may just get ripped out soon- so keep track of current OPNsense core development efforts before you go too wild fixing something- it may be rewritten and your work would be wasted!

Signed-off-by: Isaac (.ike) Levy <ike@blackskyresearch.net>
@fichtner
Copy link
Member

Saw this and like it, but would like to wait till Monday to merge. :) Thanks for your work!

@dotike
Copy link
Contributor Author

dotike commented Apr 18, 2015

No rush! Also, if you want me to clean up, squash, or move the file location, just reject this PR with notes on how you want it and I'll clean things up to spec.

Best,
.ike

fichtner added a commit that referenced this pull request Apr 20, 2015
@fichtner fichtner merged commit 3eac3eb into opnsense:master Apr 20, 2015
@fichtner
Copy link
Member

No need, looks clean enough. A bit of history is always good. Merged, cheers for this! :)

@dotike dotike deleted the locale.EN.canonical branch May 11, 2015 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants