-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host-Uniq field in PPPoE connection #1730
Conversation
|
Hi Paolo, Thanks for this. I have one question: are you sure this only applies to PPPoE? That's what the config file code assumes at the moment. Cheers, |
|
Hi Franco, I have noticed that this field also appears in PPP, PPTP, L2TP connection. Maybe I should hide it if it's not pppoe. Paolo |
|
ok let's instead keep it for all, if empty it does not cause issues anyway :) just need to move the config write block a tiny bit. I'll take care of it. |
|
alright...upon further research, it looks like a pppoe-only thing |
|
I had to change a few things, I hope you don't mind. interfaces.php also needed the GUI change. Can you test with: Cheers. |
|
Super, let's get this into 17.7 right away then. 😊 |
PR: https://forum.opnsense.org/index.php?topic=5307.0 (cherry picked from commit 7681a29)
|
Sorry I haven't fully tested the patch correctly. It needs more tweaks, I'll try better tomorrow evening and I'll post results. |
|
Your patch posted originally, or the one that I merged? |
|
Both. and it's assumed that is the binary version of you host-uniq In this way I can get IP from ISP, but I can't navigate pages (I think is a problem with my net conf). |
|
Ah, ok, try this then: |
(cherry picked from commit ac40e52)
|
Ok, I tried now and after reading the documentation of ng_pppoe it works (now I'm connected with it). I don't know if you prefer using only the "Service Name" field on the webGUI or you prefer make a code that merges the two values in a single string. Thank you 👍 I think all the people in Italy that wanted to get rid of the VodafoneStation router will be pleased. |
Add a custom field in the "advanced configuration" tab in pppoe connection page.
The custom field "host-uniq" is needed in order to connect with some ISP (for example Vodafone fiber in Italy).
Thread on forum: https://forum.opnsense.org/index.php?topic=5307.0