Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captive portal plugins access #1882

Closed
wants to merge 1 commit into from

Conversation

evbevz
Copy link
Member

@evbevz evbevz commented Oct 18, 2017

Plugins ability to register access paths to custom controllers in captive portal config.
For example, I made captive portal plugin for sms-authentication, and clients must have access to my sms-authentication controller.

@AdSchellevis AdSchellevis self-assigned this Oct 18, 2017
@AdSchellevis
Copy link
Member

@evbevz I'm not sure we should add this, there's no use case for it in the standard product, maybe it's better to look for a template include construction for custom settings so we don't have to extend the standard model (more similar like the proxy/squid approach).

@evbevz
Copy link
Member Author

evbevz commented Oct 19, 2017

For custom functionality CP template must have access to custom controller. Access to controllers is guarded by authorisation system. I can't find another way to get access to custom controller.

@AdSchellevis
Copy link
Member

@evbevz for new overwrite options, see #1934. With this you can create and maintain your own templates for the installed ones.

@evbevz evbevz deleted the captive-portal-plugins-access branch November 20, 2017 06:25
@pzwahlen
Copy link

pzwahlen commented Mar 1, 2019

@evbevz This has been rejected and closed a long time ago, however I need to solve the exact same problem and implement some sort of SMS-based captive portal. I posted in the forum a long time ago without any reply from devs (https://forum.opnsense.org/index.php?topic=9749.msg44477#msg44477).

Would you be willing to share some code samples that you used at the time or point me at a way to solve the problem using "overwrites" as mentioned by @AdSchellevis ?

Patrick

@evbevz
Copy link
Member Author

evbevz commented Mar 3, 2019

Hi, @pzwahlen. My solution has:

  • access controller with sms-auth logic
  • settings controller to store sms-gate settings
  • service controller to get some stats and current state
  • sms-athenticator implements IAuthConnector
  • proxy hook
  • captive portal config hook to get unauthorised access to access controller (it can be made by override, abouth whish @AdSchellevis says)

If you don't need proxy logs, some parts can be skipped.

@pzwahlen
Copy link

pzwahlen commented Mar 3, 2019

Hi,

I'm looking for a solution in a private environment (large house with 2 families, kids en friends...). The idea is to avoid sharing main wifi passwords and provide a somewhat bandwidth-limited guest access.

So far, the built-tin template without any authentication ("click to connect") does the job. I just wanted to improve on it, without having to use vouchers or a user DB.

I don't intend to intercept the trafic, so proxy integration won't be used.

My main concern is that the solution needs to survive upgrades, or it will be hard to maintain over time.

Would you be willing to share or can we discuss pricing for a private setup ?

Anyway, thanks a ton for having taken the time to respond.

@pzwahlen
Copy link

@evbevz Would you be willing to share your Captive Portal solution ?

@evbevz
Copy link
Member Author

evbevz commented Oct 17, 2019

@pzwahlen unfortunately I can’t share the sources anymore, as the work was done in the interests of another customer who didn’t consent to share it. sorry.

@pzwahlen
Copy link

@evbevz Thanks, this is perfectly clear and fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants