Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate 300 ms Tap Delay #2039

Merged
merged 1 commit into from Jan 4, 2018

Conversation

NOYB
Copy link
Contributor

@NOYB NOYB commented Jan 1, 2018

Implement touch-action: manipulation CSS property to eliminate 300 ms tap delay.

Does not prevent zoom. Zoom still available by pinch. Only prevents double tap zoom in order to eliminate the 300 ms tap delay.

What Exactly Is..... The 300ms Click Delay
https://www.telerik.com/blogs/what-exactly-is.....-the-300ms-click-delay

Mozilla developers page. Updated Oct 25, 2017.
https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action

W3C Recommendation - The touch-action CSS property
http://www.w3.org/TR/pointerevents/#the-touch-action-css-property

@fichtner fichtner self-assigned this Jan 2, 2018
@fichtner
Copy link
Member

fichtner commented Jan 3, 2018

this requires update of the main.scss file as well, as main.css is generated from there and this change could end up being overwritten

Implement touch-action: manipulation CSS property to eliminate 300 ms tap delay.

Does not prevent zoom.  Zoom still available by pinch.  Only prevents double tap zoom in order to eliminate the 300 ms tap delay.

What Exactly Is..... The 300ms Click Delay
https://www.telerik.com/blogs/what-exactly-is.....-the-300ms-click-delay

Mozilla developers page.  Updated Oct 25, 2017.
https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action

W3C Recommendation - The touch-action CSS property
http://www.w3.org/TR/pointerevents/#the-touch-action-css-property
@NOYB NOYB force-pushed the Eliminate_300_ms_Tap_Delay branch from 1a4bf9b to 6cd2892 Compare January 3, 2018 08:54
@fichtner fichtner merged commit fad631b into opnsense:master Jan 4, 2018
@fichtner
Copy link
Member

fichtner commented Jan 4, 2018

@NOYB oh, please ping when pushing, did not get a github notice for the update.

I'll pull this in now, thank you!

@NOYB NOYB deleted the Eliminate_300_ms_Tap_Delay branch January 4, 2018 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants