Fix IPv6 PD auto routing #2077
Closed
Fix IPv6 PD auto routing #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Jan 10, 2018
| @@ -60,7 +60,8 @@ | |||
| // echo "add routes\n"; | |||
| if (count($routes) > 0) { | |||
| foreach ($routes as $address => $prefix) { | |||
| echo "/sbin/route change -inet6 {$prefix} {$address}\n"; | |||
There was a problem hiding this comment.
hmmm, I think this is it, "route change" was a custom patch a long time ago in a project far far away
fichtner
added a commit
that referenced
this pull request
Jan 10, 2018
|
Can you try c62f01f on master instead? We should still fix the command pipe in a bit, this is fishy... but first things first. Very nice catch! |
|
Appears to work. :) Applied the patch, manually deleted the route on the primary, reset the secondary WAN and the lease is back... |
|
Thank you, I'll weave in your original changes with the next commit. Very very good find. I owe you a pint. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing exec() calls.