fix: move color settings from firewall_schedule_edit.php to theme

[fabianfrz]

No description provided.

[fabianfrz]

@marjohn56 if this gets merged, you will have to update your theme plugins.

[marjohn56]

OK. Will do so when it's merged and I can test.

[marjohn56]

I have to take a look also at René's themes, he has forwarded them to me to PR, I'll try and do all three over the next few days.

[fichtner]

thanks. but merge conflict ?

[fabianfrz]

@fichtner you changed the same line in the file - it is already fixed. If you do a squashed merge, it will be gone.

[fichtner]

You're right, thanks for the hint and the submission. 👍

[fabianfrz]

@fichtner which sass do you use for compiling, because it changed so many lines by moving brackets?

sass -v
Sass 3.5.5 (Bleeding Edge)

[fichtner]

it was @AdSchellevis's change, don't know

[AdSchellevis]

sass --version
1.3.2

[AdSchellevis]

https://sass-lang.com/dart-sass seems to be the primary implementation, which is what homebrew installs

[fabianfrz]

OK, I use the ruby one: https://sass-lang.com/ (reference implementation)

[fabianfrz]

update: it was it, now it seems to be unmaintained for the dart one.

[AdSchellevis]

ok, so, the dart version is what we should use then, isn't it?

[fabianfrz]

probably the c wrapper would fit well and it uses the original library which is also used for most programming languages: https://github.com/sass/sassc
I don't care about it as long as it compiles correctly.

[AdSchellevis]

let's stick with what the sass manual advises then :)