Swap stub-zone for forward-zone #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stub-zone doesn't work for non-authorative upstream DNS servers, but forward-zone does.
fichtner
approved these changes
Aug 17, 2018
| } | ||
| $domain_entries .= "\tstub-prime: no\n"; | ||
| //$domain_entries .= "\tstub-prime: no\n"; |
There was a problem hiding this comment.
it's better to remove stale code. we always have git history :)
There was a problem hiding this comment.
That is very true.
|
Merged, thanks! |
fichtner
added a commit
that referenced
this pull request
Aug 17, 2018
|
Thanks for merging! Not sure if you have the time for it, but any comment on the issue/forum thread connected to this? |
|
Which one? I don’t have a laptop at the moment and don’t see a link. |
|
There are plans to move to MVC, unbound and dnsmasq are good targets. We could do configd service and template regeneration without going MVC as an interim step where service rework is slightly easier than the template rework.
OTOH, it’s easy to maintain as is and works reliably. Changing it will cause a regression or two for sure and both are to be considered critical infrastructure.
I can help guide / review this work if you want to submit it.
Is that what you were asking? 😊
… On 19. Aug 2018, at 19:10, John Keates ***@***.***> wrote:
This one: https://forum.opnsense.org/index.php?topic=9279.0
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stub-zone doesn't work for non-authorative upstream DNS servers, but forward-zone does.