Fix for static IPv6 when using PPPoE IPv4 on WAN #2736
Conversation
|
For static IPv6 on top of a PPPoE this may be more suited for rc.newwanip, see my question on the Use IPv4 toggle state? |
|
Use IPv4 connectivity is checked, as it's using the PPPoE link. |
|
Ok, that means the spot you are looking for is here, no sleep required: https://github.com/opnsense/core/blob/master/src/etc/rc.newwanip#L118 Cheers, |
|
Interesting, as it only happens if you save and and apply when the interface is already up, if you take disable the interface - save & apply then enable - save & apply it's OK. |
|
We are talking static IPv6, not SLAAC or dhcp6c, even though it's using the v4 connectivity, |
|
the switch just needs: https://github.com/opnsense/core/blob/master/src/etc/inc/interfaces.inc#L2443-L2450 |
|
OK.. done that, I get warnings that the route cannot be applied, but it all seems to work fine. Hold on spaces again!!! |
|
looks good, ready for pull? :) |
|
Want kev to check his too. We may be the only two who use this strange setting. :) I've emailed him. |
|
ok, let me clean up related fluff in interfaces.inc ... that shouldn't get in the way of the merge now |
|
He'll test it and post here, but it could be tomorrow. |
|
ok, no problem. just let me know :) |
|
tested works like a charm :-) |
|
Thanks, merged! :) |
|
@marjohn56 would you mind testing this on top of master 9d37fe6 in the next few days... I made a reusable function. works for my static v4/v6, but I don't have the PPPoE / Use v4 part. |
|
My live system is now development... ooerr! Works fine. |
|
brilliant, many thanks ❤️ |
|
That bits OK, but the dev version has something amiss in the firewall, it was not allowing any of my rules for my servers, everything was hitting the default deny. |
|
@fichtner - Finally had chance to test again regarding my last comment. Dev version definately NOT working. Something is very broken in the Aliases. Firstly, the existing aliases are not imported into the GUI. Re-creating the alias entries creates some real strangeness in the config.xml and still they do not work. Going to email the xml files to you. |
|
thanks, looking at it now. we have the new aliases planned for 18.7.4 which is basically ready so worst case we have to pull 18.7.4 last minute. keep you posted. |
|
I will switch my test unit to release to check whatever is needed, won't have another chance to mess with the live unit but I can edit the aliases into the test unit config.xml |
When using a static WAN IPv6 address and using PPPoE for v4, if you save and apply the interface - this is when the interface is already up, the IPv6 address does not get applied, an error from ifconfig is generated. It appears as though the interface is not ready to accept the v6 address. This fix adds a slight delay in calling ifconfig if both the IPv6 address is static and the v4 is pppoe.
This is a fix for issue 2726 https://github.com/opnsense/core/issues/2726