System/General - Set default navigation appearance #3279
Conversation
My starting point for the following consideration was that whenever I log in to the web interface, I get the old menu view even though I almost exclusively use the collapsed menu view. so i made a new entry in the system - general tab! You can now select which menu will be displayed automatically after the login. Unfortunately I do not know how to load either the default navigation or the sidebar navigation when loading the page. Can anybody help me further? regards rené
opnsenseuser
changed the title
opnsenseuser
changed the title
src/www/system_general.php
Outdated
| <td> | ||
| <input name="navigation" class="navigation" id="navigation_standard" type="radio" value="standard" <?= $pconfig['navigation'] == "standard" ? 'checked="checked"' : '' ?>/> | ||
| <?=gettext("Standard"); ?> | ||
| |
There was a problem hiding this comment.
try to avoid non breaking spaces - it is an ugly hack from old days. you could use inline blocks etc. which have a padding and margin or switch to a select box
src/www/system_general.php
Outdated
| <br /> | ||
| <div class="hidden" data-for="help_for_navigation"> | ||
| <?=sprintf( | ||
| gettext('Set default navigation menu'));?> |
There was a problem hiding this comment.
remove the sprintf call here - it has no placeholders
|
the value is currently never used - you need to integrate them into the frontend - otherwise the setting is never applied. |
|
@fabianfrz ok. thx for your support. i will do my best and upload it again! 👍 regards rené |
|
@opnsenseuser this is a good concept, but I'm unsure about the implementation for the moment. let me think about it :) |
i did an if (!empty) command to set an value if it doesn´t exist.
…opnsenseuser/core into Choose-standard-navigation-menu
|
@fabianfrz i changed the things you said and i made an if empty command to set a value if it doesn´t exist. I hope that this command aims to set a default value if nothing is set! |
|
@opnsenseuser we probably better save this in your sessionStorage, it's more a user preference than a system preference (same as the expanded advanced section). If you need help storing it in your session storage, I can help you with that. |
|
@AdSchellevis If you could show me how that works, then I would be very grateful. I'm in a learning phase. |
|
@opnsenseuser hmm, while looking at the code, it looks like the intend was already to remember your previous setting: https://github.com/opnsense/core/blob/master/src/opnsense/www/js/opnsense_theme.js#L200-L202 https://github.com/opnsense/core/blob/master/src/opnsense/www/js/opnsense_theme.js#L209-L212 We probably should have used localstorage in there to outlive the session. |
|
@AdSchellevis I do not use cookies in my browser. for safety reasons. can it be related to that? |
|
@AdSchellevis It would still be great if we could set or save this settings to the system. Do you really not want that? then I would delete the request again. Alright? Regards rene |
|
@opnsenseuser Personally I don't see a lot of value in it, plus not all theme's might support the feature (leading to questions we don't want to answer). Without cookies enabled, local storage probably won't work. Keep it open for now, we'll discuss internally if/how we want to support this. |
|
@AdSchellevis is there any news on this topic? How did you decide? |
|
@opnsenseuser sorry, not yet, other priorities at the moment. We'll leave it open for now. |
|
@AdSchellevis I'm sorry that I'm talking to you again. Is there any news or could you possibly tell me when you want to talk about the topic? I think this idea is really good, although of course it does not have the highest priority for a firewall. Thanks and best regards, René |
|
@opnsenseuser no problem, we just haven't got time to discuss this internally. We'll let you know as soon as we do. |
|
@AdSchellevis |
|
I don't think we should do this, with cookies enabled in the browser, it already remembers your settings (as stated before) |
|
i don't use browser cookies for security reasons. furthermore it is technically solved as far as i know, that it only works as long as the current browser session is active. so no cookie is stored on the harddisc. |
|
Upon further reflection the current flexibility is nice to have the sidebar enabled on demand. If we make a setting we lose the flexibility to do this because each page load will reset the previous choice. Plus making this functional we need to inject some sort of JavaScript for this config setting to take effect which isn't ideal. For now we need to shelf this until a better strategy is found. |
My starting point for the following consideration was that whenever I log in to the web interface, I get the old menu view even though I almost exclusively use the collapsed menu view.
so i made a new entry in the system - general tab!
You can now select which menu will be displayed automatically after the login.
Saving the selected entry works fine!
Unfortunately I do not know how to load either the default navigation or the sidebar navigation as standard menu after the login. Can anybody help me further?
Regards
René