Jump to conversation
Unresolved conversations (1)
@fichtner fichtner Sep 19, 2021
This manipulates model data. Not great for maintenance or extensibility. Would be better to add constraints to model itself.
Outdated
src/opnsense/scripts/unbound/blocklists.py
shonjir kulikov-a
Resolved conversations (5)
@fichtner fichtner Sep 19, 2021
None cannot really happen… tri-state Boolean?
Outdated
src/opnsense/scripts/unbound/blocklists.py
shonjir
@fichtner fichtner Sep 19, 2021
When we require both fields this conditional can be removed.
Outdated
...tes/OPNsense/Unbound/core/blocklists.conf
shonjir
@fichtner fichtner Sep 19, 2021
„Y“ here as well
Outdated
...c/app/models/OPNsense/Unbound/Unbound.xml
shonjir
@fichtner fichtner Sep 19, 2021
Better set „Y“ here and bump model version for migration
...c/app/models/OPNsense/Unbound/Unbound.xml
shonjir
@fichtner fichtner Sep 19, 2021
Probably can have a better designation here: „dnsbl“ is too broad
Outdated
...tes/OPNsense/Unbound/core/blocklists.conf
shonjir