unbound: introducing overwriting of MX records #519
Conversation
Put Host and Domain Overrides to separate configuration section of unbound DNS resolver.
Added double click to edit domain override entry.
Added the possibility to overwrite MX records by unbound DNS resolver.
8191
changed the title
| <?php | ||
|
|
||
| /* | ||
| Copyright (C) 2014-2015 Deciso B.V. |
There was a problem hiding this comment.
This is definitely wrong. Which file did you copy? And where is your copyright? :)
There was a problem hiding this comment.
@fichtner I've copied services_unbound.php. I guess the pfSense copyright should also go along with that file, since parts of the content were moved from an existing file...
There was a problem hiding this comment.
Yup, Warren Baker needs to be added.
You can push more commits to the branch to update the pull request.
I will need to get home before I have time to test.
| if (!empty($host['descr']) && isset($config['unbound']['txtsupport'])) | ||
| /* Backwards compatibility for records created before introducing RR types. */ | ||
| if (!isset($host['rr'])) { | ||
| $host['rr'] = (is_ipaddrv6($host['ip'])) ? 'AAAA' : 'A'; |
There was a problem hiding this comment.
Here you're using "AAAA", but later you're using only "A" for both. If we do resource records, we ought to split A and AAAA.
There was a problem hiding this comment.
The idea was, that the user does not need to care about the difference between A and AAAA records, since without this PR the user does not need to care about it neither. So the differentiation between A and AAAA is done programmatically and is shown as "A/AAAA".
I have no problem in separating A and AAAA RRs...
|
Hi Manuel, Except for the two question the code looks good to me. I am only concerned with backwards compatibility and consistency in the modelling, even though it's just a temporary (0.5 to 1 year by my weak estimate) solution until we can move this to the MVC framework. Sooner or later more people will ask for different records, multiple records of the same type, etc. Cheers, |
|
Hi Franco, please see my (in-code) comments above. Regarding modelling (in)consistency; where exactly are your concerns? Manuel |
Previously it was not possible to add two host override entries for the same host-domain combination. Technically this restriction does not exist neither within unbound nor DNS.
|
@fichtner I've removed the restriction that a single host cannot be overwritten with two values, since I cannot see any technical justification for that limitation. Also sometimes it might be even required to do so, e.g. DNS round robin. |
|
@8191 cool! I'll try to get this in today :) |
|
@fichtner Great... :) |
|
Now that multiple host entries are allowed it doesn't matter. What we should do is get this in now and remodel as soon as we start the MVC code for DNS. It make sense to move the model closer to the specific domain model, so A/AAAA split we will do then. |
unbound: introducing overwriting of MX records
|
In it went, thank you very much! :) |
First PR to #511: