interfaces: VLAN priority fix for DHCPv4 #6485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires to set up the VLAN priority field of the DHCPv4 settings as well as removing the vlan-pcp option which is redundant now. This way we have a simpler approach to finding the correct value while not borrowing from IPv6 or parsing the advanced options for vlan-pcp. Leaving the old vlan-pcp in place should not matter. The last value is ours and this one should be used. PR: https://forum.opnsense.org/index.php?topic=33376.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: https://forum.opnsense.org/index.php?topic=33376.0