Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icap support #796

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Icap support #796

merged 1 commit into from
Mar 1, 2016

Conversation

fabianfrz
Copy link
Member

i think it works now but it needs some additional testing

@AdSchellevis
Copy link
Member

@fabianfrz I will pull this in now and test / optimize later today.

AdSchellevis added a commit that referenced this pull request Mar 1, 2016
@AdSchellevis AdSchellevis merged commit 90f92ad into opnsense:master Mar 1, 2016
AdSchellevis added a commit that referenced this pull request Mar 1, 2016
@AdSchellevis
Copy link
Member

@fabian I tested it on my end it all seems to be working fine, only issue I had was with c-icap, the ports version doesn't seem to be working properly for testing).
Thanks for your contribution!

@fabianfrz fabianfrz deleted the icap_support branch March 1, 2016 11:14
@fabianfrz
Copy link
Member Author

@AdSchellevis thanks for testing.
We will see what people will think about this feature.

Have a nice day,

Fabian

fichtner pushed a commit that referenced this pull request Mar 3, 2016
(cherry picked from commit 298257d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants