Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed doc regarding tunnel adress for local instance #199

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Fixed doc regarding tunnel adress for local instance #199

merged 2 commits into from
Nov 15, 2019

Conversation

marr1977
Copy link
Contributor

In step 1 the documentation says

What you receive is what WireGuard calls Allowed IP for your local instance, so edit your instance again, remove the value of Allowed IPs you used when setting up and change it to the one you got.

However, there is no "Allowed IPs" field for the local instance. I believe what should be edited is the "Tunnel Address" field of the local instance.

@fichtner fichtner self-assigned this Sep 29, 2019
mimugmail
mimugmail reviewed Sep 29, 2019
View reviewed changes
Copy link
Member

@mimugmail mimugmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We changed the wording recently, but only for Endpoint. Can you leave the first sentence like it is? WireGuard calls it Allowed IPs and we use Tunnel Address. It's just for users already using WireGuard who may be confused by this wording.

@marr1977
Copy link
Contributor Author

marr1977 commented Oct 5, 2019

Ok, reverted my change for the first sentence

@marr1977
Copy link
Contributor Author

marr1977 commented Nov 1, 2019

Was my change ok @mimugmail ?

mimugmail
mimugmail approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@mimugmail mimugmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, totally fogot this one :(

@fichtner fichtner merged commit e85cfa0 into opnsense:master Nov 15, 2019
@fichtner
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimugmail mimugmail mimugmail approved these changes

Assignees

@fichtner fichtner

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marr1977 @fichtner @mimugmail