Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynDns version 1.2_1 is broken with OPNSense 17.7.2 for NameCheap #269

Closed
liorokman opened this issue Sep 16, 2017 · 7 comments
Closed

DynDns version 1.2_1 is broken with OPNSense 17.7.2 for NameCheap #269

liorokman opened this issue Sep 16, 2017 · 7 comments
Assignees
Labels
bug Production bug

Comments

@liorokman
Copy link

The namecheap response calls a function called xml2array, which existed before updating OPNSense to version 17.7.2, but doesn't exist in OPNSense 17.7.2.

I get the following crash:

Fatal error: Uncaught Error: Call to undefined function xml2array() in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc:942 Stack trace: 
#0 /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc(735): updatedns->_checkStatus(Resource id #89, '_update() 
#2 /usr/local/etc/inc/plugins.inc.d/dyndns.inc(169): updatedns->__construct('namecheap', 'home.example.com', 'example.com', 'somepassword...', false, '', 'wan', NULL, NULL, NULL, '', true, '', '', '', 'wan', '1', false, false, false) 
#3 /usr/local/www/services_dyndns_edit.php(166): dyndns_configure_client(Array) 
#4 {main} thrown in /usr/local/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc on line 942
@fichtner fichtner self-assigned this Sep 16, 2017
@fichtner fichtner added the bug Production bug label Sep 16, 2017
@AdSchellevis
Copy link
Member

@fichtner this seemed to be buried in the upgrade_config.php we ditched. It's also in https://github.com/opnsense/core/blob/52bfec334b33f7f56d57355004a063c24c1e8965/src/www/getserviceproviders.php I'm trying to get rid of xml2array there at the moment.

@fichtner
Copy link
Member

if you want please take this as well, thanks :)

@AdSchellevis
Copy link
Member

will do

AdSchellevis added a commit to opnsense/core that referenced this issue Sep 16, 2017
fichtner pushed a commit to opnsense/core that referenced this issue Sep 16, 2017
@AdSchellevis
Copy link
Member

@liorokman this da5ae3c should do the trick, but I don't have a namecheap account to test at my end so I haven't tested all the bits together.

@fichtner
Copy link
Member

apply via command line:

# opnsense-patch -c plugins da5ae3c

@liorokman
Copy link
Author

Works like a charm.

Thanks!!!

@fichtner
Copy link
Member

fichtner commented Sep 16, 2017 via email

fichtner pushed a commit that referenced this issue Sep 17, 2017
PR: #269

(cherry picked from commit da5ae3c)
(cherry picked from commit 0bdb38b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Production bug
Development

No branches or pull requests

3 participants