Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security/acme-client: logfile is scrambled in the GUI #69

Closed
fraenki opened this issue Jan 30, 2017 · 18 comments
Closed

security/acme-client: logfile is scrambled in the GUI #69

fraenki opened this issue Jan 30, 2017 · 18 comments
Assignees
Labels
bug

Comments

@fraenki
Copy link
Member

@fraenki fraenki commented Jan 30, 2017

@fichtner: The logfile looks distorted in the GUI right now. Do you have some advise how I might fix this? :)

lelog

@fichtner fichtner self-assigned this Feb 5, 2017
@fichtner fichtner added the bug label Feb 5, 2017
@fichtner

This comment has been minimized.

Copy link
Member

@fichtner fichtner commented Feb 5, 2017

squid has a similar issue. the regex is fixed for BSD, not per daemon.

@fabianfrz

This comment has been minimized.

Copy link
Member

@fabianfrz fabianfrz commented Jul 26, 2017

@fraenki It may be the hardcore solution for your log but you can look at the log viewer of the net/quagga plugin. It gets the log from a configd call as a JSON structure and and passes it through.

@fraenki fraenki changed the title security/acme-client: logfile is scambled in the GUI security/acme-client: logfile is scrambled in the GUI Jul 31, 2017
fichtner added a commit to opnsense/core that referenced this issue Aug 28, 2017
@fichtner fichtner closed this in 24ff623 Aug 28, 2017
@fichtner

This comment has been minimized.

Copy link
Member

@fichtner fichtner commented Aug 28, 2017

@fraenki you need core commit 11f359c and plugins commit 24ff623. Core commit won't be in the 17.7.1 release, so you can try this. I added the plugin fix to 17.7.1 anyway, it is harmless. "6" was guessed from your screenshot. May be off by one. ;)

fichtner added a commit that referenced this issue Aug 28, 2017
@Woi

This comment has been minimized.

Copy link

@Woi Woi commented Sep 1, 2017

I can test opnsense/core@11f359c on top of 17.7.1 if you like me to...

@fichtner

This comment has been minimized.

Copy link
Member

@fichtner fichtner commented Sep 1, 2017

@Woi all help is welcome:

# opnsense-patch 11f359c

... but I think you know this :)

Cheers,
Franco

@Woi

This comment has been minimized.

Copy link

@Woi Woi commented Sep 2, 2017

Looks nice now 👍

@fichtner

This comment has been minimized.

Copy link
Member

@fichtner fichtner commented Sep 2, 2017

Thank you, Marco. We'll land this in 17.7.2 then :)

@Woi

This comment has been minimized.

Copy link

@Woi Woi commented Sep 4, 2017

Reporting #243, I stumbled about this bad looking line breaks in the date column, if a long log message exists:

os-acme-client_log_longlines

@fichtner

This comment has been minimized.

Copy link
Member

@fichtner fichtner commented Sep 4, 2017

This can't be fixed. It writes a proper entry per line. It's the header dump that makes this awkward. 😊

@fraenki

This comment has been minimized.

Copy link
Member Author

@fraenki fraenki commented Sep 6, 2017

This can't be fixed. It writes a proper entry per line. It's the header dump that makes this awkward.

We'll change acme.sh's default log level in the next release (#254). This will finally fix this issue :)

@fichtner

This comment has been minimized.

Copy link
Member

@fichtner fichtner commented Sep 6, 2017

@fraenki nice, thanks!

fraenki added a commit to fraenki/plugins that referenced this issue Sep 6, 2017
fichtner added a commit to opnsense/core that referenced this issue Sep 6, 2017
@StrikerTwo

This comment has been minimized.

Copy link

@StrikerTwo StrikerTwo commented Sep 15, 2017

Still broken on 17.7.2...
image

@fichtner

This comment has been minimized.

Copy link
Member

@fichtner fichtner commented Sep 15, 2017

it's not broken, literal newlines in log messages from the particular service are, er, silly...

@StrikerTwo

This comment has been minimized.

Copy link

@StrikerTwo StrikerTwo commented Sep 15, 2017

Whatever, it looks broken ;)

@fichtner

This comment has been minimized.

Copy link
Member

@fichtner fichtner commented Sep 15, 2017

ps: did you reboot? the services don't auto-restart

@StrikerTwo

This comment has been minimized.

Copy link

@StrikerTwo StrikerTwo commented Sep 15, 2017

Ah, no, I haven't. Will try that tonight.

@fraenki

This comment has been minimized.

Copy link
Member Author

@fraenki fraenki commented Sep 17, 2017

@StrikerTwo The fix changes the log setting of acme.sh, that's why it will only fix new log entries. Maybe clear the log and try again.

@StrikerTwo

This comment has been minimized.

Copy link

@StrikerTwo StrikerTwo commented Sep 18, 2017

Ah, I see. I have rebooted the box and generated some new entries in the LE log and it looks better now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.