Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme-client: DNS-01/nsupdate: doesn't allow FQDN in the name #70

Closed
lrosenman opened this issue Feb 5, 2017 · 9 comments
Closed

acme-client: DNS-01/nsupdate: doesn't allow FQDN in the name #70

lrosenman opened this issue Feb 5, 2017 · 9 comments
Assignees
Labels
bug Production bug

Comments

@lrosenman
Copy link

when you put a FQDN in a certificate name request, you get: Should be a string between 1 and 255 characters.

if you remove all the special characters (INCLUDING PERIODS(!!)), it sends the unqualified name as the CN= to LE, and gets a 400 error:

[Sun Feb 5 00:00:07 CST 2017] new-authz error: {"type":"urn:acme:error:malformed","detail":"DNS name does not have enough labels","status": 400}
[Sun Feb 5 00:00:07 CST 2017] The new-authz request is ok.

This makes it IMPOSSIBLE to generate a certiificate.
screen shot 2017-02-05 at 7 47 41 am

Also, it is unclear what is supposed to go in the secret field of the validation request. The whole key file, or just the secret or what.

screen shot 2017-02-05 at 7 51 24 am

@snetAT
Copy link

snetAT commented Feb 5, 2017

Same problem, it is not possible to use a name like srv-1.example.com

@nemesix29
Copy link

nemesix29 commented Feb 5, 2017

Same issue when my FQDN contain a hyphen.

It's possible to modify fields validation ?

@fraenki
Copy link
Member

fraenki commented Feb 5, 2017

Thanks for the report, I'm preparing a fix.

@fichtner fichtner added the bug Production bug label Feb 5, 2017
fraenki added a commit to fraenki/plugins that referenced this issue Feb 5, 2017
@fraenki
Copy link
Member

fraenki commented Feb 5, 2017

A fix is included in PR #71.

@lrosenman
Copy link
Author

Can you clarify the nsupdate secret key field?

@fraenki
Copy link
Member

fraenki commented Feb 5, 2017

@lrosenman: You need to put in the whole key file, see the example in my initial PR #66. I'll fix the help text, though.

fraenki added a commit to fraenki/plugins that referenced this issue Feb 5, 2017
fraenki added a commit to fraenki/plugins that referenced this issue Feb 5, 2017
fraenki added a commit to fraenki/plugins that referenced this issue Feb 5, 2017
@lrosenman
Copy link
Author

@fraenki Thanks!

@nemesix29
Copy link

Thanks !

@fraenki
Copy link
Member

fraenki commented Feb 7, 2017

FYI, the fix will be available on thursday with OPNsense 17.1.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Production bug
Development

No branches or pull requests

5 participants