Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP #121

Merged
merged 1 commit into from
Apr 15, 2017
Merged

BGP #121

merged 1 commit into from
Apr 15, 2017

Conversation

fabianfrz
Copy link
Member

@mimugmail this are my changes to your commits. this closes #112

@fabianfrz
Copy link
Member Author

@fichtner this is for testing

Copy link
Member

@mimugmail mimugmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one, I left this to a free text field in order to test it, because it sets "wan" in config instead for "em0".

Copy link
Member

@fichtner fichtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer retaining the original commit author or merging the other PR before this.

And don't forget to bump the version for this.

@fichtner
Copy link
Member

Super, thanks for this guys!

@fabianfrz
Copy link
Member Author

No problem. Can this be available as a dev version of the plugin?

@fichtner
Copy link
Member

It will be there automatically: os-quagga-devel is built from master branch

@fabianfrz
Copy link
Member Author

thanks, this way users like @mimugmail may test the plugin. I never used BGP so I don't know the way of configuring it. Release is next week?

@fichtner
Copy link
Member

Wednesday next week I think, depending on how testing goes for the latest core additions.

@mimugmail
Copy link
Member

I'll try to setup a big test environment in ProfitBricks and test most of the stuff.

Thanks for your help and patience with this PR 👍

@mimugmail
Copy link
Member

@fabianfrz @fichtner I setup a topology with 4 routers in a circle, upper ones in AS 65001, bottom ones in AS 65002. iBGP and eBGP work as expected and there were no issues setting up this via UI.

Only thing is that pressing the save buttons is not responsive. When I press save there's no progress, but when I switch to another menue and back, everything was saved. Also when adding a neigbor, pressing save doesn't close the window. I have to click on the X.

@fabianfrz
Copy link
Member Author

@mimugmail 👍

We can add BGPv4 to the next release if you like. 17.1.5 will come with RIP and OSPF.

So it could be included in 17.1.6 as we should have at least a (short) testing period.

@mimugmail
Copy link
Member

Great! When I'm back at work I'll start adding route-maps to BGP and a diagnostics page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants