new plugin: google-cloud-sdk, refs #1318 #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2019
fraenki
added a commit
to fraenki/tools
that referenced
this pull request
Jul 9, 2019
fichtner
pushed a commit
to opnsense/tools
that referenced
this pull request
Jul 9, 2019
|
@fichtner Well, I would merge this now, if you don't mind. |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dummy plugin in order to install the Google Cloud SDK (and to check wether it's installed programmatically).
This is mostly required for our Let's Encrypt plugin to support Google Cloud DNS API (#1318).
I've decided to create a separate plugin instead of adding it as a dependency in os-acme-client, because the SDK is relatively huge and not useful for most users.