Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new plugin: google-cloud-sdk, refs #1318 #1392

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@fraenki
Copy link
Member

commented Jul 7, 2019

This is a dummy plugin in order to install the Google Cloud SDK (and to check wether it's installed programmatically).

This is mostly required for our Let's Encrypt plugin to support Google Cloud DNS API (#1318).
I've decided to create a separate plugin instead of adding it as a dependency in os-acme-client, because the SDK is relatively huge and not useful for most users.

@fraenki fraenki self-assigned this Jul 7, 2019

@fraenki fraenki requested a review from fichtner Jul 7, 2019

fraenki added a commit to fraenki/tools that referenced this pull request Jul 7, 2019

@fabianfrz fabianfrz added the feature label Jul 9, 2019

fraenki added a commit to fraenki/tools that referenced this pull request Jul 9, 2019

fichtner added a commit to opnsense/tools that referenced this pull request Jul 9, 2019

@fraenki

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

@fichtner Well, I would merge this now, if you don't mind.

@fichtner fichtner merged commit 130323b into opnsense:master Jul 9, 2019

@fichtner

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.