dns/unbound-plus: new plugin #1495
Conversation
There was a problem hiding this comment.
This feels a bit jammed in although it would probably be what core support would look like.
What worries me a little is generating include files loosely which can’t be deleted when plugin is uninstalled and Unbound can’t trigger their generation either. Web Proxy has a bit of plugin support that tries to correct the call flow. We have to look if the same is feasible here for Unbound.
| @@ -0,0 +1,37 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Can’t we use Unbound namespace?
There was a problem hiding this comment.
Sure, would better fit when it moves to core
| cat $(find ${WORKDIR} -type f -name "*.inc") /dev/null > ${DESTDIR}/dnsbl.conf | ||
| chown unbound:unbound ${DESTDIR}/dnsbl.conf | ||
| rm -rf ${WORKDIR} | ||
| pluginctl -s unbound restart |
There was a problem hiding this comment.
People will hate you for purging their caches ;)
There was a problem hiding this comment.
Is there a smarter way? :)
There was a problem hiding this comment.
not at the moment, no. but we'll work this out later :)
|
As there is no rc.conf I used a stupid include, will have a look. I thought we agreed to start as plugin? |
|
|
||
| hbbtv() { | ||
| # HBBTV List | ||
| ${FETCH} https://raw.githubusercontent.com/Akamaru/Pi-Hole-Lists/master/hbbtv.txt -o ${WORKDIR}/hbbtv-raw |
There was a problem hiding this comment.
When I checked the link here I got a 404 page error
There was a problem hiding this comment.
Seems it was deleted, I'll remove it https://github.com/Akamaru/Pi-Hole-Lists/commit/ab5169384dacb8c71c43fa3f21903bb1f637ddcd
|
@fichtner I renamed it to Unbound but the ACL complains since it wants to overwrite the existing one in core. Any idea?: |
| type:script | ||
| message:fetching DNSBLs | ||
|
|
||
| [dnsblcron] |
There was a problem hiding this comment.
there's really no difference here in dnsbl and dnsblcron as %s is optional I think so you can merge the two
There was a problem hiding this comment.
Indeed, I remeber we did it with %s in the beginning and now both is possible
|
I would like to reengineer some of this.. with the file and the template and stuff... I do believe template dirs can have subdirectories for plugins and that would help us to start a full reconfigure from core unbound :) but for now this is ready to merge... when you're ready let me know |
|
For a 0.1 release it's good to merge :) Thanks for your time to review |
|
Merged, thanks! |
|
This is so cool... not had any time to play for a while but have a few days of peace so trying to catch up... just installed 20.* dev and installed this plugin. Well done, well done indeed. |
|
So thisi s the first user confirmation that it works? :) |
|
It passed the add blocker tests on a couple of sites. I've only added a few lists, but using some test sites it does seem to work... |
|
Great! Then I'll start adding some other features to it :) |
|
I've not tested the whitelist domains. |
Initial release for unbound-plus, add DNSBL to native Unbound DNS without the need for bind or dnscrypt-proxy.
Future version will also offer DoT or whatever may come.
dnsbl.sh need chmod as usual.