Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security/acme-client: release 1.27 #1536

Merged
merged 9 commits into from Oct 23, 2019

Conversation

@fraenki
Copy link
Member

fraenki commented Oct 10, 2019

New features

  • add support for Loopia DNS API (#1529)
  • automations can now restart Captive Portal or IPsec service after cert renewal (#1534)
  • add support for 60+ DNS APIs through Lexicon (#1524)

Bugfixes

  • don't break accounts when switching between stg/prod Let's Encrypt environments (#1528)

Enhancements

  • add py-dns-lexicon as plugin dependency to support it in DNS-01 out-of-the-box
  • support acme.sh debug log level 2 and 3 (#1546)
@fraenki fraenki self-assigned this Oct 10, 2019
security/acme-client/Makefile Outdated Show resolved Hide resolved
Co-Authored-By: Franco Fichtner <franco@lastsummer.de>
@fraenki

This comment has been minimized.

Copy link
Member Author

fraenki commented Oct 14, 2019

@fabianfrz, could you possibly do a quick review of 5866358? Thanks :)

@fabianfrz

This comment has been minimized.

in that case it would be better to just join with the "." operator.

This comment has been minimized.

Copy link
Member Author

fraenki replied Oct 20, 2019

Thx, fixed in 16dfaed.

@fabianfrz

This comment has been minimized.

CA_CONF and ACCOUNT_JSON_PATH cannot be in the same ini file?

This comment has been minimized.

Copy link
Member Author

fraenki replied Oct 20, 2019

Huh?

This comment has been minimized.

Copy link
Member

fabianfrz replied Oct 20, 2019

my fault - I misinterpreted the break - switch/for

@fabianfrz

This comment has been minimized.

with that, your file will not have a trailing newline

This comment has been minimized.

Copy link
Member Author

fraenki replied Oct 20, 2019

Thx, fixed in 6b7ffff.

@fabianfrz

This comment has been minimized.

this may require some escaping

This comment has been minimized.

Copy link
Member Author

fraenki replied Oct 20, 2019

tested it and it works as expected

@fabianfrz

This comment has been minimized.

Copy link
Member

fabianfrz commented Oct 15, 2019

@fraenki In my opinion it looks good but if you want to ensure that it does work, you could also make it more transactional by copying the resources to the new location and deleting all old directories as soon as all conversions run through.

I've commented the other things into the code.

@fraenki fraenki changed the title [WIP] security/acme-client: release 1.27 security/acme-client: release 1.27 Oct 23, 2019
@fraenki fraenki merged commit d19ea79 into opnsense:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.