Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-mgmt/zabbix-agent: add sudo rule to grant root permissions #1578

Merged
merged 3 commits into from Nov 18, 2019

Conversation

@fraenki
Copy link
Member

fraenki commented Nov 12, 2019

As discussed in opnsense/core#3777 this adds a static sudo rule for Zabbix Agent. I've added a small option so that this feature can be disabled, because it may be seen as a security risk.

(I've also took the opportunity to update the plugin's description.)

fraenki added 3 commits Nov 12, 2019
This aligns the description with other plugins. Besides that it
makes it more usable, especially in "High Availability: Settings"
the old description was pretty useless.
@fraenki fraenki added the feature label Nov 12, 2019
@fraenki fraenki self-assigned this Nov 12, 2019
@fraenki fraenki requested a review from AdSchellevis Nov 12, 2019
@fichtner

This comment has been minimized.

Copy link
Member

fichtner commented Nov 12, 2019

Static rule but wrapped in a template. We really need more precautions to remove files we otherwise leave behind on deinstall.

@fraenki

This comment has been minimized.

Copy link
Member Author

fraenki commented Nov 12, 2019

We really need more precautions to remove files we otherwise leave behind on deinstall.

Yes, that would be useful I guess. Basically all files that are generated from templates should probably be removed on deinstall.

@fichtner

This comment has been minimized.

Copy link
Member

fichtner commented Nov 12, 2019

#46 I reopened

@fraenki fraenki merged commit 30df578 into opnsense:master Nov 18, 2019
@fichtner

This comment has been minimized.

Copy link
Member

fichtner commented Nov 18, 2019

FYI: I’m not going to release until the template revoke is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.