net-mgmt/zabbix-agent: add sudo rule to grant root permissions #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the description with other plugins. Besides that it makes it more usable, especially in "High Availability: Settings" the old description was pretty useless.
|
Static rule but wrapped in a template. We really need more precautions to remove files we otherwise leave behind on deinstall. |
Yes, that would be useful I guess. Basically all files that are generated from templates should probably be removed on deinstall. |
|
#46 I reopened |
|
FYI: I’m not going to release until the template revoke is in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in opnsense/core#3777 this adds a static sudo rule for Zabbix Agent. I've added a small option so that this feature can be disabled, because it may be seen as a security risk.
(I've also took the opportunity to update the plugin's description.)