Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GoDaddy DynDNS API support #1654

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Conversation

YvanDaSilva
Copy link
Contributor

Based on the following documentation https://developer.godaddy.com/
This adds basic support for GoDaddy DynDNS REST API.

I could test the following :

  • A record
  • AAAA record
  • Invalid and Valid tokens produce the correct output in logs
  • Incorrect domain name produce the correct output in logs

More error messages and features could be handled as the API is richer than what I handled here, but this is a start

@YvanDaSilva
Copy link
Contributor Author

YvanDaSilva commented Jan 6, 2020

Known issues with this implementation:

  • To support all cases GoDaddy might require an additional field to support root and subdomain names together. This comes from the fact that the GoDaddy rest API uses the URL to split domain and host part.
  • This merge request specifically supports sub domains or a wildcard, only.

If you want a better integration, please advise on what approach would you like to see implemented:

  1. An extra field (domain, name, etc. ?)
  2. An analysis of the provided hostname to detect if it's a [hostname].[root] or [root] with all the cases that this includes "example.co.uk" << example is a root, etc.

@fichtner fichtner self-assigned this Feb 6, 2020
@timesscar
Copy link

+1 on this PR, I used this feature in pfSense and I'd love it here.

@YvanDaSilva
Copy link
Contributor Author

Hi everyone.
Sorry for this very late reply.

I didn’t have any free time available to update this branch with the feedback.
I’ll see if I can add it properly this weekend.
Best regards,

Based on the following documentation https://developer.godaddy.com/
This adds support for GoDaddy DynDNS REST API.
@YvanDaSilva
Copy link
Contributor Author

Hi @fichtner ,

Everything should be back to normal again.
But I would still advise to either add a warning to this feature based on my comments above or to complete it properly. I don't have the time to invest into this feature in the near future sadly.

Best,

@fichtner fichtner merged commit 274739b into opnsense:master Jul 17, 2020
@fichtner
Copy link
Member

Merged, thanks a lot! ❤️

@YvanDaSilva YvanDaSilva deleted the godaddy-dyndns branch July 19, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants