security/acme-client: Add NSUPDATE_ZONE support to nsupdate DNS-01 Service #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new validation.dns_nsudate_zone field to implement support for NSUPDATE_ZONE. See acmesh-official/acme.sh#1963 for more information.
Adds dns_nsupdate_zone field to model to support for NSUPDATE_ZONE. See acmesh-official/acme.sh#1963 for more information.
billgertz
changed the title
Adds new $proc_env call to process dns_update_zone to implement NSUPDATE_ZONE env variable. See acmesh-official/acme.sh#1963 for more information.
Mistake on my part, caught during review.
Mistake on a mistake <field> tag had bad alignment, it was not an unneeded tag.
Help took up three lines - shortened so it takes only two.
|
This has been tested on: Versions OPNsense 20.1.7-amd64
FreeBSD 11.2-RELEASE-p20-HBSD
OpenSSL 1.1.1g 21 Apr 2020
Using nsupdate DNS Service with nsupdate table something like: Server (FQDN) update.dyndns.com
Zone myzone.tld
Secret Key key "xxxxxxxxxxxxxxx" {
algorithm hmac-md5;
secret "xxxxxxxxxxxxxxxxxxxxxxxxxxxx";
};
Which resulted in a valid cert issued by Let's Encrypt. |
|
Ready for review and comment. If I've screwed something up - please let me know what and I will correct it straight away. |
fichtner
approved these changes
May 25, 2020
|
Merged, thanks! |
fraenki
added a commit
that referenced
this pull request
May 28, 2020
|
@fraenki Glad to be of some small help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to update nsupdate (RFC 2136) DNS Service for the Let's Encrypt module to support a Zone declaration. As described in PR#1963 for acme.sh:
Currently OPNSense is a year and a half behind what acme.sh supports for the nsupdate DNSAPI. See the acme.sh pull request for more detailed information.