Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/haproxy: support an unlimited number of SSL certificates #209

Merged
merged 2 commits into from
Jul 25, 2017

Conversation

fraenki
Copy link
Member

@fraenki fraenki commented Jul 25, 2017

A user reported that HAProxy has issues when using a large number of SSL certificates. Apparently there's a limit for maximum line length in HAProxy's configuration file according to the startup message:

[ALERT] line too long, truncating at word 65, position 1310

My patch addresses this issue by replacing crt with crt-list in HAProxy's configuration file. Our certificate exporter now creates *.crtlist files in /var/etc/haproxy/ssl/ that may contain an arbitrary number of certificate entries.

diff old vs. new configuration:

 frontend testing_frontend_ssl
-    bind opnsense-test:8443 name opnsense-test:8443 ssl crt /var/etc/haproxy/ssl/57026cd2482fa.pem crt /var/etc/haproxy/ssl/56eabc82e75ba.pem crt /var/etc/haproxy/ssl/595a40a38f0c5.pem
+    bind opnsense-test:8443 name opnsense-test:8443 ssl crt-list /var/etc/haproxy/ssl/5714b2452e6519.03813028.crtlist 

@fraenki fraenki requested a review from fichtner July 25, 2017 14:11
@fraenki fraenki self-assigned this Jul 25, 2017
@fraenki fraenki added bug Production bug feature Adding new functionality labels Jul 25, 2017
@fraenki fraenki removed the request for review from fichtner July 25, 2017 15:00
@fraenki
Copy link
Member Author

fraenki commented Jul 25, 2017

Approved by the reporter :)

@fraenki fraenki merged commit e67c481 into opnsense:master Jul 25, 2017
@fichtner
Copy link
Member

@fraenki to the rescue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Production bug feature Adding new functionality
Development

Successfully merging this pull request may close these issues.

2 participants